[rocpd] Use SQL queries instead of views in summary generator by amd-atumakae · Pull Request #311 · ROCm/rocm-systems

amd-atumakae · 2025-08-12T11:20:58Z

PR Details

Associated Jira Ticket Number/Link

SWDEV-547687

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Yes
No, Does not apply to this PR.

Updated CHANGELOG?

Yes
No, Does not apply to this PR.

Added/Updated documentation?

Yes
No, Does not apply to this PR.

🔁 Imported from ROCm/rocprofiler-sdk#102
🧑‍💻 Originally authored by @rocm-devops

ammarwa · 2025-08-12T11:45:27Z

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

yhuiYH

Probably want to get rid of get_temp_view_names function too. That'll prove that we don't need any views.

Recall, Jonathan suggested to replace any temp views and instead, use a "WITH" query in SQL.

I know, it's probably a more significant re-write, which may or may not be worth it at this point. We may want to focus on different task first.

Co-authored-by: Rahul Manocha <rmanocha@amd.com>

Co-authored-by: Rahul Manocha <rmanocha@amd.com> [ROCm/hip commit: c9b9717]

yhuiYH

These are all just minor nit pick text suggestions.

yhuiYH · 2025-08-26T04:18:45Z

It looks like summary.py test is failing on SLES (SUSE OS). I re-ran the test to see if it is still failing, but it's queued.
https://github.com/ROCm/rocm-systems/actions/runs/17209385347/job/48875551902?pr=311

It was failing on the |= operation you used. Maybe we need an alternative so it works across OSes (Ubuntu, RHEL and SLES)

yhuiYH

OK, please resolve any PR comments once you've addressed them. It also makes the PR look cleaner and easier for others to read.

yhuiYH · 2025-09-04T14:31:11Z

I think this one is ready to merge, but we can't merge due to PSDB failing (unrelated tests)

…ql_queries

(#311) * Use queries instead of views in summary.py * Export queries when created * Remove HIP and HSA from output * Fix domain query * Export summary queries in the main function * Fix comments and variable names * Change syntax for old python versions [rocm-systems] ROCm/rocm-systems#311 (commit 646e4d2)

* Use queries instead of views in summary.py * Export queries when created * Remove HIP and HSA from output * Fix domain query * Export summary queries in the main function * Fix comments and variable names * Change syntax for old python versions --------- Co-authored-by: Young Hui <young.hui@amd.com>

Changes: - Changed HIP_UUID to reference rsmi_dev_unique_id_get() - Added better logging for amdsmi_get_gpu_device_uuid() references Change-Id: Ie233044de8c6e85b807faf22121b450233db861b Signed-off-by: Charis Poag <Charis.Poag@amd.com>

Changes: - Changed HIP_UUID to reference rsmi_dev_unique_id_get() - Added better logging for amdsmi_get_gpu_device_uuid() references Change-Id: Ie233044de8c6e85b807faf22121b450233db861b Signed-off-by: Charis Poag <Charis.Poag@amd.com> [ROCm/amdsmi commit: 817c077]

A copy paste mistake in a previous commit caused source and dest to be reversed. Correct the source and dest params. Fixes: 6de67d5 Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>

A copy paste mistake in a previous commit caused source and dest to be reversed. Correct the source and dest params. Fixes: e8a7371 Signed-off-by: Allen Hubbe <allen.hubbe@amd.com> [ROCm/rocshmem commit: e2dcf99]

github-actions Bot added the project: rocprofiler-sdk label Aug 12, 2025

systems-assistant Bot added the organization: ROCm label Aug 12, 2025

amd-atumakae added the rocpd label Aug 12, 2025

amd-atumakae requested a review from yhuiYH August 12, 2025 14:05

yhuiYH reviewed Aug 13, 2025

View reviewed changes

Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py Outdated

Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py Outdated

amd-atumakae force-pushed the atumakae/summary_sql_queries branch from 3e5ba67 to a2693be Compare August 18, 2025 14:09

amd-atumakae requested a review from yhuiYH August 18, 2025 17:05

systems-assistant Bot pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-545952 - Header changes for hipStreamSet/GetAttribute (#311)

c9b9717

Co-authored-by: Rahul Manocha <rmanocha@amd.com>

jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-545952 - Header changes for hipStreamSet/GetAttribute (#311)

59536c1

Co-authored-by: Rahul Manocha <rmanocha@amd.com> [ROCm/hip commit: c9b9717]

amd-atumakae force-pushed the atumakae/summary_sql_queries branch from a2693be to d045a71 Compare August 20, 2025 11:09

yhuiYH reviewed Aug 20, 2025

View reviewed changes

Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py Outdated

Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py Outdated

amd-atumakae force-pushed the atumakae/summary_sql_queries branch 2 times, most recently from 1b9926f to b58e81e Compare August 21, 2025 15:02

yhuiYH reviewed Aug 22, 2025

View reviewed changes

Comment thread projects/rocprofiler-sdk/source/lib/python/rocpd/summary.py Outdated

amd-atumakae force-pushed the atumakae/summary_sql_queries branch from b58e81e to f3a7611 Compare August 25, 2025 12:51

amd-atumakae marked this pull request as ready for review August 25, 2025 12:56

amd-atumakae requested review from jrmadsen and t-tye as code owners August 25, 2025 12:56

amd-atumakae force-pushed the atumakae/summary_sql_queries branch from f3a7611 to 8820edd Compare August 26, 2025 12:18

yhuiYH approved these changes Aug 26, 2025

View reviewed changes

yhuiYH added ready for 2nd review rocprofiler-sdk: Ready for 2nd code review labels Aug 26, 2025

jrmadsen approved these changes Aug 27, 2025

View reviewed changes

amd-atumakae force-pushed the atumakae/summary_sql_queries branch from 8820edd to b5a8dd8 Compare August 28, 2025 20:47

amd-atumakae added 3 commits September 2, 2025 14:58

Use queries instead of views in summary.py

9034816

Export queries when created

6bb24ca

Remove HIP and HSA from output

822a746

amd-atumakae added 4 commits September 2, 2025 14:58

Fix domain query

bd5c0b1

Export summary queries in the main function

a72ae93

Fix comments and variable names

e5c8191

Change syntax for old python versions

6de2e41

amd-atumakae force-pushed the atumakae/summary_sql_queries branch from b5a8dd8 to 6de2e41 Compare September 2, 2025 15:10

bwelton self-assigned this Sep 2, 2025

yhuiYH added ready to merge and removed ready for 2nd review rocprofiler-sdk: Ready for 2nd code review labels Sep 4, 2025

Merge remote-tracking branch 'origin/develop' into atumakae/summary_s…

4e163b1

…ql_queries

yhuiYH merged commit 646e4d2 into develop Sep 15, 2025
30 of 38 checks passed

yhuiYH deleted the atumakae/summary_sql_queries branch September 15, 2025 21:13

anujshuk-amd mentioned this pull request Dec 12, 2025

fix: Prevent segfaults from thread ID array overflow #2172

Merged

1 task

Conversation

amd-atumakae commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Updated CHANGELOG?

Added/Updated documentation?

Uh oh!

ammarwa commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

Uh oh!

yhuiYH left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yhuiYH left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yhuiYH commented Aug 26, 2025

Uh oh!

yhuiYH left a comment

Choose a reason for hiding this comment

Uh oh!

yhuiYH commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

amd-atumakae commented Aug 12, 2025 •

edited

Loading

ammarwa commented Aug 12, 2025 •

edited

Loading