Skip to content

Enable MARKER_CORE_RANGE_API in json-tool #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MythreyaK wants to merge 2 commits into from
Closed

Enable MARKER_CORE_RANGE_API in json-tool #776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce57548
Enable `MARKER_CORE_RANGE_API` in json-tool
MythreyaK Jul 30, 2025
144f60f
enable MARKER_CORE_API
MythreyaK Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 74 additions & 17 deletions projects/rocprofiler-sdk/tests/tools/json-tool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,14 +1430,14 @@ tool_init(rocprofiler_client_finalize_t fini_func, void* tool_data)
nullptr),
"marker core api tracing service configure");

// ROCPROFILER_CALL(rocprofiler_configure_callback_tracing_service(
// marker_api_callback_ctx,
// ROCPROFILER_CALLBACK_TRACING_MARKER_CORE_RANGE_API,
// nullptr,
// 0,
// tool_tracing_callback,
// nullptr),
// "marker core api tracing service configure");
ROCPROFILER_CALL(rocprofiler_configure_callback_tracing_service(
marker_api_callback_ctx,
ROCPROFILER_CALLBACK_TRACING_MARKER_CORE_RANGE_API,
nullptr,
0,
tool_tracing_callback,
nullptr),
"marker core range api tracing service configure");

ROCPROFILER_CALL(rocprofiler_configure_callback_tracing_service(
marker_api_callback_ctx,
Expand Down Expand Up @@ -1781,15 +1781,15 @@ tool_init(rocprofiler_client_finalize_t fini_func, void* tool_data)
nullptr,
0,
marker_api_buffered_buffer),
"buffer tracing service configure");
"buffer tracing service configure - MARKER_CORE_API");

// ROCPROFILER_CALL(rocprofiler_configure_buffer_tracing_service(
// marker_api_buffered_ctx,
// ROCPROFILER_BUFFER_TRACING_MARKER_CORE_RANGE_API,
// nullptr,
// 0,
// marker_api_buffered_buffer),
// "buffer tracing service configure");
ROCPROFILER_CALL(rocprofiler_configure_buffer_tracing_service(
marker_api_buffered_ctx,
ROCPROFILER_BUFFER_TRACING_MARKER_CORE_RANGE_API,
nullptr,
0,
marker_api_buffered_buffer),
"buffer tracing service configure");

ROCPROFILER_CALL(
rocprofiler_configure_buffer_tracing_service(marker_api_buffered_ctx,
Expand Down Expand Up @@ -2546,6 +2546,61 @@ write_perfetto()
auto buffer_names = sdk::get_buffer_tracing_names();
auto callbk_name_info = sdk::get_callback_tracing_names();

for(const auto& itr : marker_api_bf_records)
{
std::string_view name = "<unknown-marker-name>";
auto& track = thread_tracks.at(itr.thread_id);

auto _args = callback_arg_array_t{};
if(enable_debug_annotations)
{
using namespace std::string_view_literals;

auto ritr = std::find_if(marker_api_cb_records.begin(),
marker_api_cb_records.end(),
[&itr](const auto& citr) {
return (citr.record.correlation_id.internal ==
itr.correlation_id.internal &&
!citr.args.empty());
});

if(ritr != marker_api_cb_records.end())
{
auto elem =
std::find_if(ritr->args.cbegin(), ritr->args.cend(), [](const auto& arg) {
return arg.first == "message"sv;
});
if(elem != ritr->args.end())
{
name = elem->second;
}
}
}

TRACE_EVENT_BEGIN(sdk::perfetto_category<sdk::category::marker_api>::name,
::perfetto::StaticString(name.data()),
track,
itr.start_timestamp,
::perfetto::Flow::ProcessScoped(itr.correlation_id.internal),
"begin_ns",
itr.start_timestamp,
"tid",
itr.thread_id,
"kind",
itr.kind,
"operation",
itr.operation,
"corr_id",
itr.correlation_id.internal,
"ancestor_id",
itr.correlation_id.ancestor);
TRACE_EVENT_END(sdk::perfetto_category<sdk::category::marker_api>::name,
track,
itr.end_timestamp,
"end_ns",
itr.end_timestamp);
}

for(const auto& itr : hsa_api_bf_records)
{
auto name = buffer_names.at(itr.kind, itr.operation);
Expand Down Expand Up @@ -2840,7 +2895,9 @@ write_perfetto()
"dst_agent",
agents_map.at(itr.dst_agent_id).logical_node_id,
"copy_bytes",
itr.bytes);
itr.bytes,
"corr_id",
itr.correlation_id.internal);
TRACE_EVENT_END(sdk::perfetto_category<sdk::category::memory_copy>::name,
track,
itr.end_timestamp,
Expand Down
Loading