Enable MARKER_CORE_RANGE_API in json-tool#776
Closed
MythreyaK wants to merge 2 commits into
Closed
Conversation
12 tasks
MythreyaK
force-pushed
the
users/mkuriche/json-tool-marker-api
branch
from
a4f45d5 to
65354c2
Compare
* Add perfetto output to json tool * misc formatting
MythreyaK
force-pushed
the
users/mkuriche/json-tool-marker-api
branch
from
65354c2 to
144f60f
Compare
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #179.
Motivation
Enables marker core range API in the json tool and perfetto output for marker ranges. This change should make it easier to debug tests which use marker API.
This change would be helpful for a memory copy tracing test that I plan to add in the near future because it makes it much easier to both visualize (with perfetto dumps) and walk the call stack with ancestor IDs.
Technical Details
MARKER_CORE_APIbuffer and callback to tracingTest Plan
Test Result
Submission Checklist