Skip to content

Handle build warnings Removing All #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
essamROCm wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Handle build warnings Removing All #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4918b53
1st round of warnning cause removal
essamROCm Mar 31, 2026
5e6c078
2nd round testing on TheRock, fixing warnings cause
essamROCm Apr 6, 2026
8a9d472
Fix bug for CI build
essamROCm Apr 6, 2026
261a61d
small test/runtime bug fixes
essamROCm Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 58 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,33 @@ else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -DNDEBUG -fPIC")
endif()

option(ROCPYDECODE_ENABLE_ALL_WARNINGS "Enable broad compiler warnings for C++ targets" ON)
set(ROCPYDECODE_WARNING_FLAGS "")
if(ROCPYDECODE_ENABLE_ALL_WARNINGS)
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
list(APPEND ROCPYDECODE_WARNING_FLAGS
-Weverything
-Wno-c++98-compat
-Wno-c++98-compat-pedantic
-Wno-pre-c++14-compat
-Wno-pre-c++17-compat
-Wno-pre-c++20-compat)
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
list(APPEND ROCPYDECODE_WARNING_FLAGS
-Wall
-Wextra
Copy link
Copy Markdown
Contributor

@LakshmiKumar23 LakshmiKumar23 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not enabling extra and pedantic on our other libraries. Some of the numeric check with -Wextra are too strict. We should discuss this.

-Wpedantic)
elseif(MSVC)
list(APPEND ROCPYDECODE_WARNING_FLAGS
/W4
/permissive-)
endif()

if(ROCPYDECODE_WARNING_FLAGS)
add_compile_options(${ROCPYDECODE_WARNING_FLAGS})
endif()
endif()

# Set supported GPU Targets
if(NOT GPU_TARGETS AND NOT AMDGPU_TARGETS)
set(DEFAULT_GPU_TARGETS "gfx908;gfx90a;gfx942;gfx1030;gfx1031;gfx1032;gfx1100;gfx1101;gfx1102;gfx950;gfx1200;gfx1201")
Expand Down Expand Up @@ -160,12 +187,19 @@ set (HIP_PLATFORM amd CACHE STRING "HIP platform")

# Find dependencies
find_package(HIP REQUIRED)
find_package(rocdecode 1.0.0 QUIET)
find_package(rocjpeg 1.0.0 QUIET)
# ROCm package versions are currently 0.x even though the APIs used here are stable.
Copy link
Copy Markdown
Contributor

@LakshmiKumar23 LakshmiKumar23 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is incorrect, the version of rocDecode on TheRock now brings in 1.8.0 and rocjpeg is 1.4.0. Please keep the versioning check

(rock_0408) lakshmi@kapu:~/work/lk/rpp/build$ ls /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/lib/librocdecode.so
librocdecode.so        librocdecode.so.1      librocdecode.so.1.8.0

(rock_0408) lakshmi@kapu:~/work/lk/rpp/build$ ls /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/lib/librocjpeg.so
librocjpeg.so        librocjpeg.so.1      librocjpeg.so.1.4.0

find_package(rocdecode QUIET)
find_package(rocjpeg QUIET)
find_package(pybind11 REQUIRED)
find_package(DLPACK REQUIRED)
find_package(FFmpeg QUIET)
set(ROCPYDECODE_USE_FFMPEG ${FFMPEG_FOUND})
set(ROCPYDECODE_USE_FFMPEG FALSE)
set(ROCPYDECODE_FFMPEG_UTILS_DIR "${ROCM_PATH}/share/rocdecode/utils/ffmpegvideodecode")
if(FFMPEG_FOUND AND EXISTS "${ROCPYDECODE_FFMPEG_UTILS_DIR}/ffmpeg_video_dec.h")
set(ROCPYDECODE_USE_FFMPEG TRUE)
elseif(FFMPEG_FOUND)
message(STATUS "FFmpeg found, but rocdecode FFmpeg utility sources are unavailable; building without demux/CPU backend.")
endif()

set(ROCPYDECODE_DEPENDENCY_READY FALSE)
set(ROCPYJPEG_DEPENDENCY_READY FALSE)
Expand All @@ -180,8 +214,17 @@ if(rocdecode_FOUND)
include_directories(src)
file(GLOB pyfiles pyRocVideoDecode/*.py pyRocVideoDecode/*.pyi)

# TBD (essam):
# # The always-built rocdecode utility sources use libavutil's MD5 helpers.
# if(AVUTIL_LIBRARY)
# list(APPEND LINK_LIBRARY_LIST ${AVUTIL_LIBRARY})
# else()
# message(FATAL_ERROR "libavutil is required to build rocPyDecode because ROCm's roc_video_dec utilities use av_md5_* symbols.")
# endif()

# Always build the GPU path
include_directories(${rocdecode_INCLUDE_DIR}
include_directories(SYSTEM
Copy link
Copy Markdown
Contributor

@LakshmiKumar23 LakshmiKumar23 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this SYSTEM do here?

${rocdecode_INCLUDE_DIR}
${ROCM_PATH}/include/rocdecode
${ROCM_PATH}/share/rocdecode/utils
${ROCM_PATH}/share/rocdecode/utils/rocvideodecode)
Expand All @@ -205,17 +248,25 @@ if(rocdecode_FOUND)
# Core GPU sources
file(GLOB include_base src/rocdecode/*.h src/common/*.h ${ROCM_PATH}/share/rocdecode/utils/rocvideodecode/*.h)
file(GLOB sources_base src/rocdecode/roc_pydecode.cpp src/rocdecode/roc_pyvideodecode.cpp src/common/*.cpp ${ROCM_PATH}/share/rocdecode/utils/*.cpp ${ROCM_PATH}/share/rocdecode/utils/rocvideodecode/*.cpp)
file(GLOB sources_external_rocdecode ${ROCM_PATH}/share/rocdecode/utils/*.cpp ${ROCM_PATH}/share/rocdecode/utils/rocvideodecode/*.cpp)
set(include ${include_base})
set(sources ${sources_base})
if(sources_external_rocdecode)
set_source_files_properties(${sources_external_rocdecode} PROPERTIES COMPILE_OPTIONS "-w")
endif()

if(ROCPYDECODE_USE_FFMPEG)
# Demux + CPU backend (FFmpeg-dependent)
file(GLOB sources_ffmpeg src/rocdecode/roc_pyvideodemuxer.cpp src/rocdecode/roc_pyvideodecodecpu.cpp src/rocdecode/roc_pydecode_test.cpp ${ROCM_PATH}/share/rocdecode/utils/ffmpegvideodecode/*.cpp)
file(GLOB include_ffmpeg ${ROCM_PATH}/share/rocdecode/utils/ffmpegvideodecode/*.h)
file(GLOB sources_external_ffmpeg ${ROCM_PATH}/share/rocdecode/utils/ffmpegvideodecode/*.cpp)
list(APPEND include ${include_ffmpeg})
list(APPEND sources ${sources_ffmpeg})
include_directories(${AVUTIL_INCLUDE_DIR} ${AVCODEC_INCLUDE_DIR} ${AVFORMAT_INCLUDE_DIR})
include_directories(SYSTEM ${AVUTIL_INCLUDE_DIR} ${AVCODEC_INCLUDE_DIR} ${AVFORMAT_INCLUDE_DIR})
Copy link
Copy Markdown
Contributor

@LakshmiKumar23 LakshmiKumar23 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above?

set(LINK_LIBRARY_LIST ${LINK_LIBRARY_LIST} ${FFMPEG_LIBRARIES})
if(sources_external_ffmpeg)
set_source_files_properties(${sources_external_ffmpeg} PROPERTIES COMPILE_OPTIONS "-w")
endif()
else()
message(STATUS "FFmpeg not found; building rocPyDecode without demux/CPU backend (GPU decode only).")
set(ROCPYDECODE_HOST_LIBRARY_FOUND FALSE)
Expand All @@ -225,7 +276,7 @@ else()
endif()
# rocJPEG
if(rocjpeg_FOUND)
include_directories(${rocjpeg_INCLUDE_DIR} ${ROCM_PATH}/share/rocjpeg/samples)
include_directories(SYSTEM ${ROCM_PATH}/include ${rocjpeg_INCLUDE_DIR} ${ROCM_PATH}/share/rocjpeg/samples)
Copy link
Copy Markdown
Contributor

@LakshmiKumar23 LakshmiKumar23 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

set(LINK_LIBRARY_LIST_JPEG ${LINK_LIBRARY_LIST_JPEG} rocjpeg::rocjpeg)

file(GLOB pyfiles_jpeg pyRocJpegDecode/*.py pyRocJpegDecode/*.pyi)
Expand All @@ -247,6 +298,7 @@ else()
message("-- ${Yellow}rocPyJPEG skipped -- missing rocjpeg dependency${ColourReset}")
endif()
message("-- ${White}rocPyDecode/rocPyJPEG -- CMAKE_CXX_FLAGS:${CMAKE_CXX_FLAGS}${ColourReset}")
message("-- ${White}rocPyDecode/rocPyJPEG -- Warning Flags:${ROCPYDECODE_WARNING_FLAGS}${ColourReset}")

# set license information
set(CPACK_RPM_PACKAGE_LICENSE "MIT")
Expand Down
6 changes: 2 additions & 4 deletions samples/rocjpeg/jpegdecode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

import torch
import pyRocJpegDecode.decoder as jdec
import rocpyjpegdecode.jpegTypes as jpegt
import argparse
Expand Down Expand Up @@ -57,8 +56,7 @@ def jpeg_decode(
# example how to save the decoded image as a file
if (output_file_path is not None):
filename = output_file_path.strip() + ".png"
img1 = torch.from_numpy(img_tensor.to_numpy())
arr = img1.cpu().numpy()
arr = img_tensor.to_numpy()
img = Image.fromarray(arr.astype(np.uint8))
img.save(filename)
print(f"Image saved as: {filename}")
Expand Down Expand Up @@ -121,4 +119,4 @@ def jpeg_decode(
print("ERROR: input passed with -i must be an existing file.")
exit()

jpeg_decode(input_file_path, output_format, device_id, backend, output_file_path)
jpeg_decode(input_file_path, output_format, device_id, backend, output_file_path)
Loading