Handle build warnings Removing All#274
Conversation
essamROCm
requested review from
AryanSalmanpour,
LakshmiKumar23,
kiritigowda and
rrawther
as code owners
|
@AryanSalmanpour @rrawther @LakshmiKumar23 @kiritigowda |
| find_package(HIP REQUIRED) | ||
| find_package(rocdecode 1.0.0 QUIET) | ||
| find_package(rocjpeg 1.0.0 QUIET) | ||
| # ROCm package versions are currently 0.x even though the APIs used here are stable. |
There was a problem hiding this comment.
this comment is incorrect, the version of rocDecode on TheRock now brings in 1.8.0 and rocjpeg is 1.4.0. Please keep the versioning check
(rock_0408) lakshmi@kapu:~/work/lk/rpp/build$ ls /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/lib/librocdecode.so
librocdecode.so librocdecode.so.1 librocdecode.so.1.8.0
(rock_0408) lakshmi@kapu:~/work/lk/rpp/build$ ls /home/lakshmi/rock_0408/lib/python3.10/site-packages/_rocm_sdk_devel/lib/librocjpeg.so
librocjpeg.so librocjpeg.so.1 librocjpeg.so.1.4.0
|
|
||
| # Always build the GPU path | ||
| include_directories(${rocdecode_INCLUDE_DIR} | ||
| include_directories(SYSTEM |
There was a problem hiding this comment.
What does this SYSTEM do here?
| list(APPEND include ${include_ffmpeg}) | ||
| list(APPEND sources ${sources_ffmpeg}) | ||
| include_directories(${AVUTIL_INCLUDE_DIR} ${AVCODEC_INCLUDE_DIR} ${AVFORMAT_INCLUDE_DIR}) | ||
| include_directories(SYSTEM ${AVUTIL_INCLUDE_DIR} ${AVCODEC_INCLUDE_DIR} ${AVFORMAT_INCLUDE_DIR}) |
| # rocJPEG | ||
| if(rocjpeg_FOUND) | ||
| include_directories(${rocjpeg_INCLUDE_DIR} ${ROCM_PATH}/share/rocjpeg/samples) | ||
| include_directories(SYSTEM ${ROCM_PATH}/include ${rocjpeg_INCLUDE_DIR} ${ROCM_PATH}/share/rocjpeg/samples) |
| # find requirements (optional to allow skipping tests) | ||
| find_package(rocdecode 1.0.0 QUIET) | ||
| find_package(rocjpeg 1.0.0 QUIET) | ||
| find_package(rocdecode QUIET) |
There was a problem hiding this comment.
same comment as other. Why are we removing versioning check?
| elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| list(APPEND ROCPYDECODE_WARNING_FLAGS | ||
| -Wall | ||
| -Wextra |
There was a problem hiding this comment.
We are not enabling extra and pedantic on our other libraries. Some of the numeric check with -Wextra are too strict. We should discuss this.
| using namespace py::literals; | ||
|
|
||
| namespace { | ||
| template <typename Target, typename Source> |
There was a problem hiding this comment.
All this seems like some numeric checks needed by -Wextra. Not sure we want to enable it. We have only -Wall so far in other libraries. let us discuss
2 participants
Motivation
Enable build warnings and modify code to remove the warning causes.
Technical Details
Effect many source code files.
Test Plan
Same ctest
Tested on ROCm and TheRock environment.
Test Result
ALL PASS