pkg/nanocbor: fix decoding of indefinite arrays and maps#15411
Closed
benpicco wants to merge 3 commits into
Closed
pkg/nanocbor: fix decoding of indefinite arrays and maps#15411benpicco wants to merge 3 commits into
benpicco wants to merge 3 commits into
Conversation
Add a test that serializes a config and then decodes it to see if the result matches the original.
benpicco
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
benpicco
added
Area: pkg
Contributor
|
ping @bergzand ! |
benpicco
added
CI: ready for build
Contributor
Author
|
bergzand/NanoCBOR#31 provides an alternative fix for the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
There is a bug in NanoCBOR that prevents decoding of indefinite elements.
An out-of-tree patch exists to fix that, include this in our pkg.
Testing procedure
A test was added to
tests/pkg_nanocborto test encoding / decoding of an indefinite map.The test will fail on
master.Issues/PRs references
upstream PR bergzand/NanoCBOR#21