Skip to content

Scanner rpc active#264

Merged
r2dedios merged 22 commits into
RHEcosystemAppEng:release-0.6from
r2dedios:scanner-rpc-active
Jun 1, 2026
Merged

Scanner rpc active#264
r2dedios merged 22 commits into
RHEcosystemAppEng:release-0.6from
r2dedios:scanner-rpc-active

Conversation

@r2dedios

@r2dedios r2dedios commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR merges the scanner-rpc-active branch into release-0.6, bringing the scanner redesign and a series of console and backend improvements:

Scanner Redesign

  • Redesign scanner as a long-running gRPC service replacing the previous CronJob-based approach
  • Add API readiness check, account seeding, and billing optimization
  • New proto definitions and generated gRPC code for scanner service

Events & Actions Backend

  • Rename triggered_by to requester across the entire stack (DB schema, Go models, DTOs, repositories, services, handlers, API contracts) for consistent naming
  • Persist requester and description in the schedule table so the Agent preserves requester identity through the polling cycle
  • Add schedule_id, resource_name, and account_name to event views for richer audit data
  • Add Account resource type to the audit event system
  • Handle NULL columns in system events and schedule models

Console — Audit Logs & Scheduler

  • Redesign Audit Logs table with operation labels, resource badges, status labels, and linked schedule actions
  • Redesign Scheduler table: add ID, Requester, Description columns; merge Time/Cron into unified Schedule column; Yes/No enabled labels
  • Add cronstrue for human-readable cron expressions

Console — Account Details

  • Add "Actions" dropdown with Scan option to Account Details page
  • Confirmation modal before triggering account scan
  • Creates an InstantAction targeting the specific account

Console — General Improvements

  • Add ResourceBadge and ResourceLabel components with styled action labels
  • Unify Target column rendering across tables
  • Align Recent Events (Overview) table with Audit Logs rendering (same labels, badges, timestamps)
  • Add error handling to action creation API calls in both Account and Cluster dropdowns
  • Replace ModalPowerManagement with ModalCreateAction
  • Fix resource path resolution and handle empty resourceId

Infrastructure

  • Update Helm templates and compose files for scanner service
  • Pin container image and deployment configuration

Test plan

  • make go-unit-tests — all pass
  • make console-lint — 0 errors
  • Manual: verify Audit Logs table renders with operation labels, resource badges, and status labels
  • Manual: verify Scheduler table shows ID, Requester, Description, unified Schedule column
  • Manual: verify Account Details → Actions → Scan creates an instant scan action
  • Manual: verify Overview Recent Events matches Audit Logs rendering
  • Manual: verify requester is populated in Audit Logs after Agent processes actions

@r2dedios r2dedios self-assigned this Jun 1, 2026
@r2dedios r2dedios added the enhancement New feature or request label Jun 1, 2026
@r2dedios r2dedios added this to the v0.6 milestone Jun 1, 2026
@r2dedios r2dedios marked this pull request as ready for review June 1, 2026 13:34
@r2dedios r2dedios merged commit ecf984f into RHEcosystemAppEng:release-0.6 Jun 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant