Skip to content

fix(links): add missing filter based on serviceId #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmnbrd merged 1 commit into from
Feb 23, 2026
Merged

fix(links): add missing filter based on serviceId #2411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libs/domains/services/feature/src/lib/service-links-popover/service-links-popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ export function ServiceLinksPopover({

// Remove default Qovery links
const filteredLinks = useMemo(
() => links.filter((link: LinkProps) => !(link.is_default && link.is_qovery_domain)),
[links]
() =>
links.filter((link: LinkProps) => !(link.is_default && link.is_qovery_domain) && link.service_id === serviceId),
[links, serviceId]
)

// Separate links into nginx and gateway-api groups
Expand Down