Skip to content

Comments

fix(links): add missing filter based on serviceId#2411

Merged
rmnbrd merged 1 commit intostagingfrom
fix/QOV-1013/links-request-filter
Feb 23, 2026
Merged

fix(links): add missing filter based on serviceId#2411
rmnbrd merged 1 commit intostagingfrom
fix/QOV-1013/links-request-filter

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Feb 23, 2026

Summary

PR #2408 introduced an issue where all links were appearing in the links popover, instead of being filtered based on the serviceId

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 939e824e-ace5-46db-852e-4db251209aeb test-prod-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview e68a6997-01bc-4a01-adcd-e763ade8d2ae test-prod-clone-pipeline-clone-test
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@rmnbrd rmnbrd self-assigned this Feb 23, 2026
@rmnbrd rmnbrd marked this pull request as ready for review February 23, 2026 15:27
@rmnbrd rmnbrd requested review from RemiBonnet and benjaminch and removed request for benjaminch February 23, 2026 15:27
@rmnbrd rmnbrd merged commit af019ef into staging Feb 23, 2026
9 checks passed
@rmnbrd rmnbrd deleted the fix/QOV-1013/links-request-filter branch February 23, 2026 15:37
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.290.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.72%. Comparing base (9ca3e8d) to head (ab6aa50).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...ib/service-links-popover/service-links-popover.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2411      +/-   ##
===========================================
+ Coverage    48.39%   48.72%   +0.32%     
===========================================
  Files          939      696     -243     
  Lines        19288    15471    -3817     
  Branches      5753     4651    -1102     
===========================================
- Hits          9335     7538    -1797     
+ Misses        8181     6512    -1669     
+ Partials      1772     1421     -351     
Flag Coverage Δ
unittests 48.72% <0.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants