Skip to content

Enrich visualizer info panel attributes #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BioCam merged 3 commits into from
Mar 27, 2026
Merged

Enrich visualizer info panel attributes #974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b10c8ea
add missing resource attributes to visualizer info panel
BioCam Mar 27, 2026
98190ce
show `height_volume_data` presence in visualizer panel
BioCam Mar 27, 2026
c5cbd78
address Copilot suggestions
BioCam Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 39 additions & 14 deletions pylabrobot/visualizer/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,10 @@ class Resource {
this.resourceType = resourceData.type || this.constructor.name;
this.category = resourceData.category || "";
this.methods = resourceData.methods || [];
this.model = resourceData.model || null;
this.rotation = resourceData.rotation || null;
this.barcode = resourceData.barcode || null;
this.preferred_pickup_location = resourceData.preferred_pickup_location || null;

this.color = "#5B6D8F";

Expand Down Expand Up @@ -1002,6 +1006,10 @@ class Resource {
size_z: this.size_z,
children: serializedChildren,
parent_name: this.parent === undefined ? null : this.parent.name,
model: this.model,
rotation: this.rotation,
barcode: this.barcode,
preferred_pickup_location: this.preferred_pickup_location,
};
}

Expand Down Expand Up @@ -1342,6 +1350,7 @@ class Container extends Resource {
this.maxVolume = max_volume;
this.volume = resourceData.volume || 0;
this.material_z_thickness = material_z_thickness;
this.has_height_volume_data = resourceData.height_volume_data != null;
}

static _liquidRGB = null;
Expand Down Expand Up @@ -1401,14 +1410,16 @@ class Well extends Container {

constructor(resourceData, parent) {
super(resourceData, parent);
const { cross_section_type } = resourceData;
const { cross_section_type, bottom_type } = resourceData;
this.cross_section_type = cross_section_type;
this.bottom_type = bottom_type || null;
}

serialize() {
return {
...super.serialize(),
cross_section_type: this.cross_section_type,
bottom_type: this.bottom_type,
};
}

Expand Down Expand Up @@ -4378,33 +4389,47 @@ function getUmlAttributes(resource) {
var attrs = [];
attrs.push({ key: "name", value: JSON.stringify(resource.name) });
attrs.push({ key: "type", value: resource.resourceType || resource.constructor.name });
attrs.push({ key: "children", value: resource.children ? resource.children.length : 0 });
if (resource.model) {
attrs.push({ key: "model", value: resource.model });
}
var abs = resource.getAbsoluteLocation();
attrs.push({ key: "abs_location", value: "(" + abs.x.toFixed(1) + ", " + abs.y.toFixed(1) + ", " + (abs.z || 0).toFixed(1) + ")" });
if (resource.rotation) {
attrs.push({ key: "rotation", value: "(" + resource.rotation.x + ", " + resource.rotation.y + ", " + resource.rotation.z + ")" });
}
attrs.push({ key: "size_x", value: resource.size_x });
attrs.push({ key: "size_y", value: resource.size_y });
attrs.push({ key: "size_z", value: resource.size_z });
if (resource.location) {
attrs.push({ key: "location", value: "(" + resource.location.x + ", " + resource.location.y + ", " + (resource.location.z || 0) + ")" });
}
var abs = resource.getAbsoluteLocation();
attrs.push({ key: "abs_location", value: "(" + abs.x.toFixed(1) + ", " + abs.y.toFixed(1) + ", " + (abs.z || 0).toFixed(1) + ")" });
attrs.push({ key: "parent", value: resource.parent ? JSON.stringify(resource.parent.name) : "none" });
attrs.push({ key: "children", value: resource.children ? resource.children.length : 0 });
if (resource.category) {
attrs.push({ key: "category", value: resource.category });
if (resource.barcode) {
attrs.push({ key: "barcode", value: resource.barcode.data + " (" + resource.barcode.symbology + ", " + resource.barcode.position_on_resource + ")" });
}
if (resource.preferred_pickup_location) {
var ppl = resource.preferred_pickup_location;
attrs.push({ key: "preferred_pickup_location", value: "(" + ppl.x + ", " + ppl.y + ", " + ppl.z + ")" });
}

// Well-specific (before general Container attrs)
if (resource instanceof Well) {
if (resource.cross_section_type) {
attrs.push({ key: "cross_section_type", value: resource.cross_section_type });
}
if (resource.bottom_type) {
attrs.push({ key: "bottom_type", value: resource.bottom_type });
}
}
// Container (Well/Trough/Tube)
if (resource instanceof Container) {
attrs.push({ key: "max_volume", value: resource.maxVolume });
attrs.push({ key: "volume", value: resource.volume });
if (resource.material_z_thickness != null) {
attrs.push({ key: "material_z_thickness", value: resource.material_z_thickness });
}
}
// Well-specific
if (resource instanceof Well) {
if (resource.cross_section_type) {
attrs.push({ key: "cross_section_type", value: resource.cross_section_type });
}
attrs.push({ key: "height_volume_data", value: resource.has_height_volume_data ? "exists" : "None" });
attrs.push({ key: "max_volume", value: resource.maxVolume });
attrs.push({ key: "volume", value: resource.volume });
}
// TipSpot
if (resource instanceof TipSpot) {
Expand Down
Loading