✨ [Artifact 1315] ドルフィンダイブを作成#1719
Draft
Lapis-LJA wants to merge 10 commits into
Draft
Conversation
haiiro2gou
reviewed
May 23, 2026
| # Durationを0にしてエフェクト解除 | ||
| data modify storage asset:context Duration set value 0 | ||
|
|
||
| tp @s @s |
Member
There was a problem hiding this comment.
nits: tp @s @s の実装意図は書いたほうがいいと思う
Comment on lines
+38
to
+39
| # フィールド | ||
| data modify storage asset:effect Field.Delay set value 6 |
Member
There was a problem hiding this comment.
頭打っても着地してしばらくしたら発動するじゃん、ヤバそう
Contributor
There was a problem hiding this comment.
Pull request overview
このPRは、新神器「ドルフィンダイブ」（Artifact 1315）を追加し、発動時の跳躍→着地判定→着地時AoEダメージ＆演出（水柱Object召喚）までを、Artifact/Effect/Objectの各レイヤーで実装・登録する変更です。
Changes:
- Effect 0341「ドルフィンダイブ」を追加し、tickで着地（地面/水面）判定して着地処理（攻撃Object召喚）を実行
- Object 1151「dolphin_dive」を追加し、tick進行に合わせた波状のダメージ判定と水柱Object（2256）の召喚を実行
- Artifact 1315「ドルフィンダイブ」を追加し、give/register/trigger と各種タグ（click/give/register, effect tick/register）へ登録
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Asset/data/asset/tags/functions/effect/tick.json | Effect 0341 のtickディスパッチャを登録 |
| Asset/data/asset/tags/functions/effect/register.json | Effect 0341 のregisterディスパッチャを登録 |
| Asset/data/asset/tags/functions/artifact/register.json | Artifact 1315 のregisterを登録 |
| Asset/data/asset/tags/functions/artifact/give.json | Artifact 1315 のgiveトリガを登録 |
| Asset/data/asset/tags/functions/artifact/click.carrot_on_a_stick.json | carrot_on_a_stick clickトリガに Artifact 1315 を追加 |
| Asset/data/asset/functions/object/alias/1151/tick.mcfunction | Object 1151 tick のエイリアス追加 |
| Asset/data/asset/functions/object/alias/1151/summon.mcfunction | Object 1151 summon のエイリアス追加 |
| Asset/data/asset/functions/object/alias/1151/register.mcfunction | Object 1151 register のエイリアス追加 |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/summon/max_start.mcfunction | 水柱Objectを最大寄りフレームで召喚する補助 |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/summon/.mcfunction | 水柱Object(2256)の召喚処理 |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/damage/check_duplicate.mcfunction | 多重ヒット防止＋ダメージ＋ノックバックの共通処理 |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/damage/1.mcfunction | Wave1の当たり判定・ダメージ・モーション |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/damage/2.mcfunction | Wave2の当たり判定・ダメージ・モーション |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/damage/3.mcfunction | Wave3の当たり判定・ダメージ・モーション |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/1.mcfunction | Wave1のSFX/VFX（水柱召喚） |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/2.mcfunction | Wave2のSFX/VFX（水柱召喚） |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/wave/3.mcfunction | Wave3のSFX/VFX（水柱召喚） |
| Asset/data/asset/functions/object/1151.dolphin_dive/tick/.mcfunction | Object 1151 のtick本体（Tick進行・Wave発火・kill） |
| Asset/data/asset/functions/object/1151.dolphin_dive/summon/.mcfunction | Object 1151 のベースEntity召喚 |
| Asset/data/asset/functions/object/1151.dolphin_dive/register.mcfunction | Object 1151 のデータ登録（Extends/Fieldなど） |
| Asset/data/asset/functions/effect/0341.dolphin_dive/tick/landing.mcfunction | 着地時にEffect解除し、攻撃Object(1151)を召喚 |
| Asset/data/asset/functions/effect/0341.dolphin_dive/tick/.mcfunction | Effect tick（演出、Delay、着地/水面判定） |
| Asset/data/asset/functions/effect/0341.dolphin_dive/register.mcfunction | Effect 0341 のメタデータ登録 |
| Asset/data/asset/functions/effect/0341.dolphin_dive/_/tick.mcfunction | Effect tickディスパッチャ（id:341） |
| Asset/data/asset/functions/effect/0341.dolphin_dive/_/register.mcfunction | Effect registerディスパッチャ（id:341） |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/trigger/vfx.mcfunction | Artifact発動時の演出パーティクル |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/trigger/predicate/water_surface.mcfunction | 水面（足元が水＆目線が水中でない）判定 |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/trigger/predicate/on_ground.mcfunction | 地面接地判定 |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/trigger/3.main.mcfunction | Artifactメイン処理（演出、モーション、Effect付与） |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/trigger/2.check_condition.mcfunction | 発動条件チェック（地面 or 水面） |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/trigger/1.trigger.mcfunction | mainhand装備ID一致でチェック処理へ |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/register.mcfunction | 神器プール登録（RarityRegistry） |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/give/2.give.mcfunction | 神器アイテム定義（Lore/Cost/Cooldown等） |
| Asset/data/asset/functions/artifact/1315.dolphin_dive/give/1.trigger.mcfunction | giveディスパッチャ（id:1315） |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by ProjectTSB/TheSkyBlessing#2163