Skip to content

fix(ui): ensure dark mode coherence across charting components #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Priyanshu-byte-coder merged 1 commit into from
May 30, 2026
+9 −9
Merged

fix(ui): ensure dark mode coherence across charting components #1552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ComparisonChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export default function ComparisonChart({
wrapperStyle={{ fontSize: "12px", paddingTop: "10px" }}
/>
<Bar dataKey="me" fill="var(--accent)" radius={[4, 4, 0, 0]} maxBarSize={28} />
<Bar dataKey="friend" fill="#6366f1" radius={[4, 4, 0, 0]} maxBarSize={28} />
<Bar dataKey="friend" fill="var(--accent-secondary)" radius={[4, 4, 0, 0]} maxBarSize={28} />
</BarChart>
</ResponsiveContainer>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/MiniPRTrendChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ export default function MiniPRTrendChart() {
}

let strokeColor = "var(--accent)";
if (stats.trendText === "Improving") strokeColor = "#16a34a";
if (stats.trendText === "Degrading") strokeColor = "#dc2626";
if (stats.trendText === "Improving") strokeColor = "var(--success)";
if (stats.trendText === "Degrading") strokeColor = "var(--destructive)";

return (
<div className="mt-4 flex h-16 w-full items-center justify-between gap-4 rounded-lg bg-[var(--control)] p-3 border border-[var(--border)]">
Expand Down
8 changes: 4 additions & 4 deletions src/components/PRBreakdownChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ interface PRBreakdown {
}

const SLICES: { key: keyof PRBreakdown; label: string; color: string }[] = [
{ key: "open", label: "Open", color: "#6366f1" },
{ key: "merged", label: "Merged", color: "#34d399" },
{ key: "closed", label: "Closed", color: "#fb923c" },
{ key: "draft", label: "Draft", color: "#94a3b8" },
{ key: "open", label: "Open", color: "var(--accent)" },
{ key: "merged", label: "Merged", color: "var(--success)" },
{ key: "closed", label: "Closed", color: "var(--warning)" },
{ key: "draft", label: "Draft", color: "var(--muted-foreground)" },
];

export default function PRBreakdownChart() {
Expand Down
4 changes: 2 additions & 2 deletions src/components/repo-analytics/RepoTimelineChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ export default function RepoTimelineChart({ timeline }: { timeline: TimelinePoin
<Line
type="monotone"
dataKey="prs"
stroke="var(--chart-cyan)"
stroke="var(--accent-secondary)"
strokeWidth={2}
dot={false}
/>
<Line
type="monotone"
dataKey="issues"
stroke="var(--chart-orange)"
stroke="var(--warning)"
strokeWidth={2}
dot={false}
/>
Expand Down
Loading