Skip to content

fix(ui): ensure dark mode coherence across charting components#1552

Merged
Priyanshu-byte-coder merged 1 commit into
Priyanshu-byte-coder:mainfrom
ArshVermaGit:main_7
May 30, 2026
Merged

fix(ui): ensure dark mode coherence across charting components#1552
Priyanshu-byte-coder merged 1 commit into
Priyanshu-byte-coder:mainfrom
ArshVermaGit:main_7

Conversation

@ArshVermaGit
Copy link
Copy Markdown
Contributor

Description

This PR resolves an issue where third-party charting libraries (Recharts) used hardcoded hex colors, causing visual clashes when the dashboard was toggled into dark mode. By passing the semantic CSS variables defined in globals.css directly to the charting components, all data visualizations now adapt elegantly to the active theme.

Resolved Issue

Resolves #1551

Key Changes

  • PRBreakdownChart.tsx: Updated PR status slices to use semantic variables (var(--accent), var(--success), var(--warning), var(--muted-foreground)).
  • ComparisonChart.tsx: Updated the comparison bar graph to use var(--accent-secondary) instead of a hardcoded indigo hex value.
  • MiniPRTrendChart.tsx: Swapped hardcoded green/red stroke colors for var(--success) and var(--destructive).
  • RepoTimelineChart.tsx: Replaced undefined chart CSS variables with var(--accent-secondary) and var(--warning).
  • Audited: Verified that CodingTimeWidget, PRReviewTrendChart, CommitTimeChart, and PRStatusDonutChart already correctly leverage theme tokens.
  • Design Decision: Preserved standard GitHub branding colors (e.g., TypeScript blue, JavaScript yellow) to maintain language recognition.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • UI/UX Improvement

How Has This Been Tested?

  • Toggled between Light and Dark mode to ensure text, axes, tooltips, and data series contrast properly in both themes.
  • Ran npm run build to verify that all modifications compile without type errors.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@ArshVermaGit is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) labels May 29, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown
Contributor Author

@ArshVermaGit ArshVermaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Priyanshu-byte-coder ! Issue #1551 has been resolved. Please review the PR and merge it under GSSoC. Thanks!

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level2 GSSoC Level 2 - Medium complexity (25 points) labels May 30, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder merged commit 745c576 into Priyanshu-byte-coder:main May 30, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level2 GSSoC Level 2 - Medium complexity (25 points) type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Design Polish: Dark Mode Coherence in Charts & Data Visualizations

2 participants