[codex] reject invalid timers promises args#4354
Closed
andrewtdiz wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing as duplicate. PR #4351 covers the same timers/promises validation gap with the better Node-matching setInterval iterator behavior and has now been validated with the full timers parity module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:timers/promisesdelay/options/ref validation failures into rejected promises instead of synchronous throws.setInterval()calls whosenext()rejects with the Node-shaped validation error.Verification
cargo check -p perry-runtimecargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shCARGO_BUILD_JOBS=1 RUSTC_WRAPPER= CARGO_PROFILE_RELEASE_LTO=false CARGO_PROFILE_RELEASE_CODEGEN_UNITS=16 CARGO_PROFILE_RELEASE_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_RUNTIME_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_STDLIB_OPT_LEVEL=1 cargo build --release -p perry -p perry-runtime -p perry-stdlibCARGO_BUILD_JOBS=1 RUSTC_WRAPPER= CARGO_PROFILE_RELEASE_LTO=false CARGO_PROFILE_RELEASE_CODEGEN_UNITS=16 CARGO_PROFILE_RELEASE_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_RUNTIME_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_STDLIB_OPT_LEVEL=1 PATH="/root/.npm/_npx/bac97da9607b7ef2/node_modules/node/bin:$PATH" PERRY_NO_AUTO_OPTIMIZE=1 ./run_parity_tests.sh --suite node-suite --module timers --filter validation(4 pass, 0 fail, 0 compile fail)CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= CARGO_PROFILE_RELEASE_LTO=false CARGO_PROFILE_RELEASE_CODEGEN_UNITS=16 CARGO_PROFILE_RELEASE_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_RUNTIME_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_STDLIB_OPT_LEVEL=1 PATH="/root/.npm/_npx/bac97da9607b7ef2/node_modules/node/bin:$PATH" PERRY_NO_AUTO_OPTIMIZE=1 ./run_parity_tests.sh --suite node-suite --module timers(90 pass, 0 fail, 0 compile fail)Refs #2013.