Skip to content

[codex] reject invalid timers promises args#4354

Closed
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-timers-promises-validation
Closed

[codex] reject invalid timers promises args#4354
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-timers-promises-validation

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

Verification

  • cargo check -p perry-runtime
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= CARGO_PROFILE_RELEASE_LTO=false CARGO_PROFILE_RELEASE_CODEGEN_UNITS=16 CARGO_PROFILE_RELEASE_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_RUNTIME_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_STDLIB_OPT_LEVEL=1 cargo build --release -p perry -p perry-runtime -p perry-stdlib
  • CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= CARGO_PROFILE_RELEASE_LTO=false CARGO_PROFILE_RELEASE_CODEGEN_UNITS=16 CARGO_PROFILE_RELEASE_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_RUNTIME_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_STDLIB_OPT_LEVEL=1 PATH="/root/.npm/_npx/bac97da9607b7ef2/node_modules/node/bin:$PATH" PERRY_NO_AUTO_OPTIMIZE=1 ./run_parity_tests.sh --suite node-suite --module timers --filter validation (4 pass, 0 fail, 0 compile fail)
  • CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= CARGO_PROFILE_RELEASE_LTO=false CARGO_PROFILE_RELEASE_CODEGEN_UNITS=16 CARGO_PROFILE_RELEASE_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_RUNTIME_OPT_LEVEL=1 CARGO_PROFILE_RELEASE_PACKAGE_PERRY_STDLIB_OPT_LEVEL=1 PATH="/root/.npm/_npx/bac97da9607b7ef2/node_modules/node/bin:$PATH" PERRY_NO_AUTO_OPTIMIZE=1 ./run_parity_tests.sh --suite node-suite --module timers (90 pass, 0 fail, 0 compile fail)

Refs #2013.

@andrewtdiz
Copy link
Copy Markdown
Contributor Author

Closing as duplicate. PR #4351 covers the same timers/promises validation gap with the better Node-matching setInterval iterator behavior and has now been validated with the full timers parity module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant