[codex] reject timers promises validation errors#4351
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Validated this exact branch ( Additional validation run:
I am closing #4354 as a duplicate in favor of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delay,options, andoptions.refvalidation innode:timers/promisespromise helpers.setInterval()shape by returning an async iterator and rejecting the first.next()promise for validation errors..next().Root Cause
Perry already built Node-shaped
TypeError [ERR_INVALID_ARG_TYPE]values for these validators, but it threw them synchronously from the native helper before returning a promise or iterator. Node returns rejected promises forsetTimeout,setImmediate, andscheduler.wait, and deferssetIntervalvalidation to the iterator's.next()promise.Validation
cargo build -p perry -p perry-runtime -p perry-stdlibcargo test -p perry-runtime timers_promises --libcargo fmt --all -- --checkgit diff --checktest-parity/node-suite/timers/promises/delay-options-validation.tstest-parity/node-suite/timers/promises/ref-option-validation.tsimports.ts,scheduler-not-callable.ts,set-immediate-signal.tsRefs #2013.