[codex] add Ink compilePackages smoke CI#4347
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #803
Summary
This wires the existing
tests/release/packages/ink-link-smokefixture into the Tests workflow as a named extended CI job. The job runs on version tags, onworkflow_dispatchwithrun_extended_tests=true, and on PRs labeledrun-extended-tests, matching the existing expensive package-smoke pattern.The PR also refreshes the Ink fixture so the new job is actually green on current main:
perry.compilePackages/perry.allow.compilePackageslist to include the locked Ink transitive package graph;perry.experiments.treeShakeand production/dev defines for the fixture;yoga-layout's WASM-backed default export after install, keeping this link-only fixture focused on the package graph and native symbol surface rather than runtime layout execution;Why this cut
#803 asks for a CI job around a canonical Ink compilePackages program. The fixture already existed, but running it on current main exposed stale trust metadata and a yoga WASM bootstrap link symbol. Keeping the CI job and fixture repairs together avoids landing a job that would be red immediately.
Tests and checks
bash -n tests/release/packages/ink-link-smoke/fixture.sh && bash -n tests/release/packages/_harness.sh && bash -n tests/release/packages/_fixture_lib.sh.github/workflows/test.ymlandtests/release/packages/ink-link-smoke/package.jsoncargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shcargo build --release -p perry-runtime -p perry-stdlib -p perryCARGO_BUILD_JOBS=1 cargo build --release -j1 -p perry-runtime -p perry-stdlib -p perrypassed.cd tests/release/packages/ink-link-smoke && PERRY_BIN=/root/perry-worktrees/perry-node-ink-ci-smoke/target/release/perry bash fixture.shpassed.PERRY_BIN=/root/perry-worktrees/perry-node-ink-ci-smoke/target/release/perry tests/release/packages/_harness.sh --filter ink-link-smokepassed: 1 passed, 0 failed, 0 skipped.Known limitations
This remains compile/link-only. It does not execute Ink rendering, does not validate yoga-layout runtime behavior, and does not claim end-to-end TUI compatibility.
Non-goals
ink(React-based TUI framework) end-to-end viaperry.compilePackages#348 runtime/rendering behavior;