fix: resolve thread safety, dead code, and memory leak in rf_mapper.py#2428
Open
Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Open
fix: resolve thread safety, dead code, and memory leak in rf_mapper.py#2428Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Conversation
…ice cleanup - Add scan_lock (threading.Lock) to protect scan_results, scan_idx, and scan_last_sent from race conditions between _scan_task and run threads - Remove unused seen_names variable (dead code) - Add TTL cleanup in scan() to remove BLE devices not seen for >60s to prevent memory leak on long-running sessions
github-actions
bot
added
robotics
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Add -> bool return type to stop_after_one and raise_keyboard_interrupt to match RFmapper.sleep(duration: float) -> bool signature - Fixes pyright reportAttributeAccessIssue in CI/CD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#1771
Summary
This PR addresses the issues reported and adds one additional fix
discovered during code review.
Changes
Point 1: Thread Safety (Critical)
scan_results,scan_idx, andscan_last_sentwere accessed by two threads(
_scan_taskandrun) without synchronization, causing potential raceconditions and data loss.
self.scan_lock = threading.Lock()in__init__scan_resultsand increment ofscan_idxin_scan_taskandscan()scan_results,scan_idx, andscan_last_sentinrun()Point 2: Remove Unused Variable (Dead Code)
self.seen_names: List[str] = []was declared but never referenced anywherein the codebase. Removed entirely.
Point 3: Deprecated
logging.warn()Already fixed
Memory Leak in
seen_devicesDiscovered during code review:
seen_deviceswas never cleaned up, causingBLE devices to accumulate in memory indefinitely on long-running sessions.
scan()to remove devicesnot seen for more than 60 seconds