Skip to content

fix(tui): convert COMMANDS list to immutable tuple #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tui): convert COMMANDS list to immutable tuple #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openhands_cli/tui/core/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@


# Available commands with descriptions after the command
COMMANDS = [
COMMANDS: tuple[DropdownItem, ...] = (
DropdownItem(main="/help - Display available commands"),
DropdownItem(main="/new - Start a new conversation"),
DropdownItem(main="/history - Toggle conversation history"),
Expand All @@ -25,7 +25,7 @@
DropdownItem(main="/skills - View loaded skills, hooks, and MCPs"),
DropdownItem(main="/feedback - Send anonymous feedback about CLI"),
DropdownItem(main="/exit - Exit the application"),
]
)


def get_valid_commands() -> set[str]:
Expand Down
4 changes: 2 additions & 2 deletions tests/tui/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ class TestCommands:
"""Tests for command definitions and handlers."""

def test_commands_list_structure(self):
"""Test that COMMANDS list has correct structure."""
assert isinstance(COMMANDS, list)
"""Test that COMMANDS tuple has correct structure."""
assert isinstance(COMMANDS, tuple)
assert len(COMMANDS) == 9

# Check that all items are DropdownItems
Expand Down