fix(tui): convert COMMANDS list to immutable tuple#767
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(tui): convert COMMANDS list to immutable tuple#767github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Converts the module-level COMMANDS list to a tuple to prevent accidental mutation at runtime. Updates test assertion to expect tuple. Addresses item from code quality report. Related to #766 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the module-level COMMANDS list to an immutable tuple to prevent accidental mutation at runtime.
Changes
COMMANDSfrom list totuple[DropdownItem, ...]intui/core/commands.pytest_commands.pyto expect tuple instead of listRelated Issue
Addresses findings from #766
Testing
make lint)make test)This PR was automatically generated by the Code Quality Report workflow.
This PR was created by an AI agent (OpenHands) on behalf of the user.