Skip to content

Accept legacy QuackbackConfig discriminator in config schema #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BunsDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Accept legacy QuackbackConfig discriminator in config schema #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/web/src/lib/server/config-file/__tests__/schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@ describe('parseQuackbackConfig', () => {
expect(result.success).toBe(true)
})

it('accepts the rebranded config kind', () => {
const result = parseQuackbackConfig({
apiVersion: 'quackback.io/v1',
kind: 'quackbackConfig',
spec: {},
})
expect(result.success).toBe(true)
})

it('rejects a missing apiVersion', () => {
const result = parseQuackbackConfig({ kind: 'QuackbackConfig', spec: {} })
expect(result.success).toBe(false)
Expand Down
4 changes: 3 additions & 1 deletion apps/web/src/lib/server/config-file/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ const authSchema = z
export const quackbackConfigSchema = z
.object({
apiVersion: z.literal('quackback.io/v1'),
kind: z.literal('QuackbackConfig'),
// Accept both the original public discriminator and the rebranded
// spelling so existing managed deployments continue to reconcile.
kind: z.enum(['QuackbackConfig', 'quackbackConfig']),
metadata: z.object({ source: z.string().optional() }).strict().optional(),
spec: z
.object({
Expand Down