Accept legacy QuackbackConfig discriminator in config schema#38
Open
BunsDev wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores backward compatibility for declarative config YAMLs by allowing both the legacy and rebranded kind discriminator values in the server-side Zod schema, preventing existing managed deployments from being rejected during config reconciliation.
Changes:
- Updated
quackbackConfigSchema.kindto accept bothQuackbackConfig(legacy) andquackbackConfig(rebranded). - Added a unit test asserting
parseQuackbackConfigacceptskind: 'quackbackConfig'.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/src/lib/server/config-file/schema.ts | Broadens the Zod discriminator validation to accept both legacy and rebranded kind values. |
| apps/web/src/lib/server/config-file/tests/schema.test.ts | Adds coverage ensuring the rebranded kind value is accepted by parseQuackbackConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
79165c9 to
3bc3168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
kindliteral fromQuackbackConfigtoquackbackConfig, which rejects existing managed YAMLs and prevents the config watcher from reconciling managed workspace/auth settings; this patch restores compatibility so existing deployments continue to apply managed settings.Description
kind: z.literal('quackbackConfig')tokind: z.enum(['QuackbackConfig', 'quackbackConfig'])inapps/web/src/lib/server/config-file/schema.tsso legacy files are still valid.kind: 'quackbackConfig'is accepted inapps/web/src/lib/server/config-file/__tests__/schema.test.tswhile preserving existing tests that useQuackbackConfig.parseQuackbackConfigAPI and types (QuackbackConfig,QuackbackConfigSpec).Testing
parseQuackbackConfigacceptskind: 'quackbackConfig'(test file:apps/web/src/lib/server/config-file/__tests__/schema.test.ts).apps/web/src/lib/server/config-file/__tests__/schema.test.ts, plus loader/watcher tests) but execution was blocked due to dependency resolution failing to fetchvitestfrom the registry (403) becausenode_modulesare not present; tests could not be executed in this environment.Codex Task