Skip to content

fix: guard against empty/filtered LLM responses in openai adapter #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qizwiz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard against empty/filtered LLM responses in openai adapter #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions agentverse/llms/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ def generate_response(
functions=functions,
**self.args.dict(),
)
if not response.choices or response.choices[0].message is None:
raise ValueError("LLM returned empty or filtered response")

logger.log_prompt(
[
Expand Down Expand Up @@ -281,6 +283,8 @@ def generate_response(
messages=messages,
**self.args.dict(),
)
if not response.choices or response.choices[0].message is None:
raise ValueError("LLM returned empty or filtered response")
logger.log_prompt(
[
{
Expand Down Expand Up @@ -335,6 +339,8 @@ async def agenerate_response(
functions=functions,
**self.args.dict(),
)
if not response.choices or response.choices[0].message is None:
raise ValueError("LLM returned empty or filtered response")
logger.log_prompt(
[
{
Expand Down Expand Up @@ -415,6 +421,8 @@ async def agenerate_response(
messages=messages,
**self.args.dict(),
)
if not response.choices or response.choices[0].message is None:
raise ValueError("LLM returned empty or filtered response")
self.collect_metrics(response)
logger.log_prompt(
[
Expand Down
7 changes: 5 additions & 2 deletions agentverse/memory/chat_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,15 @@ async def _update_summary_with_batch(
summary=self.summary, new_events=new_events_batch
)

self.summary = await openai_client.chat.completions.acreate(
_resp = await openai_client.chat.completions.acreate(
messages=[{"role": "user", "content": prompt}],
model=model,
max_tokens=max_summary_length,
temperature=0.5,
).choices[0].message.content
)
if not _resp.choices or _resp.choices[0].message is None:
raise ValueError("LLM returned empty or filtered response")
self.summary = _resp.choices[0].message.content

def summary_message(self) -> dict:
return {
Expand Down
2 changes: 2 additions & 0 deletions scripts/evaluate_responsegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def write_eval_to_file(file, skip=0):
time.sleep(min(i**2, 60))
continue
break
if not eval_response.choices or eval_response.choices[0].message is None:
raise ValueError("LLM returned empty or filtered response")
text = eval_response.choices[0].message.content
eval.append(text)
text = text.replace("\n", "\n\n")
Expand Down