fix: guard against empty/filtered LLM responses in openai adapter#159
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty/filtered LLM responses in openai adapter#159qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
An empty choices list raises IndexError; a None message (returned by some providers on filtered content with HTTP 200) raises AttributeError. Add null checks in generate_response, agenerate_response, evaluate_responsegen, and chat_history.summarize_memory before accessing choices[0].message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds null checks before accessing
choices[0].messagein three files:agentverse/llms/openai.py—generate_responseandagenerate_response(4 locations)scripts/evaluate_responsegen.py— eval loopagentverse/memory/chat_history.py—summarize_memoryWhy
The OpenAI SDK can return two silent failure modes that cause unhandled crashes:
IndexError—choicesis an empty list ([]) when the provider returns no completionsAttributeError—choices[0].messageisNonewhen content is filtered (e.g. Gemini returns HTTP 200 withPROHIBITED_CONTENTfinish reason)Both crash the agent mid-task with an unhelpful traceback rather than a clear error.
Fix
This converts both failure modes into a single, descriptive
ValueErrorthat callers can catch and handle.Detected by pact static analysis.