CBC rz sweep chunk#1050
Open
eappen-nelluvelil wants to merge 2 commits into
Open
Conversation
aa31b60 to
8ff48ba
Compare
1fe0c91 to
82cb31c
Compare
Contributor
Author
|
@wdarylhawkins @quocdang1998 Rebased PR on top of #1008. Once 1008 is merged, I'll update this PR remove 1008's commits. |
d80ff9d to
3ed4e1c
Compare
5b1b708 to
2490314
Compare
Contributor
Author
|
@wdarylhawkins @quocdang1998 Removed PR #1008 's commits from this PR, and it should be good to merge. |
andrsd
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Note: This PR builds on top of PR #1008. Once #1008 has been merged, this PR will be updated to remove #1008's commits and retain only the latest 2 commits. **~59% of the changes from the latest 2 commits come from regression tests. **
This PR adds host CBC support for 2D$r-z$ problems and corresponding regression tests adapted from the existing AAH tests. AAH and CBC $r-z$ sweep chunks reuse fixed-node SIMD-vectorized sweep kernel utilities where applicable.
The following CBC-specific absolute tolerances needed minimal adjustments relative to the corresponding AAH tests to get them to pass:
abs_tolchangetransport_2d_cyl_2g_scatter_vacuum_cbc.pyG0_MAXtransport_2d_cyl_2g_scatter_vacuum_cbc.pyG1_MAXtransport_2d_cyl_disk_leakage_reflecting_bcs_cbc.pySide leakage=transport_2d_cyl_disk_leakage_reflecting_bcs_cbc.pyTotal leakage=