Host CBC handles cycles#1060
Open
eappen-nelluvelil wants to merge 4 commits into
Open
Conversation
eappen-nelluvelil
force-pushed
the
cbc-cycles-4
branch
from
19a9461 to
6ee7db5
Compare
andrsd
reviewed
May 13, 2026
andrsd
reviewed
May 13, 2026
Collaborator
|
I looked over the code. It seems fairly good to me. Also, it seems like you need some more wrappers in mpicpp-lite. I can add those and ping you here when done... |
eappen-nelluvelil
force-pushed
the
cbc-cycles-4
branch
4 times, most recently
from
facaf75 to
642fede
Compare
eappen-nelluvelil
force-pushed
the
cbc-cycles-4
branch
from
642fede to
69c9dbf
Compare
eappen-nelluvelil
force-pushed
the
cbc-cycles-4
branch
from
69c9dbf to
b7208f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Note: This PR builds on top of PR #1008 and PR #1050. Once 1008 and 1050 have been merged, only the latest 2 commits will be retained.
This PR updates host CBC's SPDS, FLUDS, and async communicator so FAS edges in local/inter-partition cycles are treated as lagged dependencies, and
CBC_FLUDSmanages additional delayed flux banks.Device CBC support for handling cyclic dependencies was not added here. PR #1028 will be updated to allow CBCD V2 to handle cyclic dependencies.