CBC/CBCD with minimally sized FLUDS#1028
Draft
eappen-nelluvelil wants to merge 6 commits into
Draft
Conversation
690cbbe to
a9dfacb
Compare
Contributor
Author
|
@wdarylhawkins @quocdang1998 The Note: This regression test now passes. |
andrsd
reviewed
Apr 16, 2026
quocdang1998
requested changes
Apr 17, 2026
a6b6905 to
b7747ef
Compare
Contributor
Author
|
@wdarylhawkins @quocdang1998 Switching this to a draft PR until I get back access to Tuo compute banks to update scaling studies. |
b7747ef to
dbe4bc7
Compare
dbe4bc7 to
d38db2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
The scope is limited to the latest three commits:
68ff405,45e29dc, anda6b6905. The first 3 commits are from PR #1008. This PR will be updated to remove those commits once they are merged intomain.Commit 1
CBC_SPDSnow computes an exact static cell-face slot plan for local psi banks.Commit 2
CBC_FLUDSuses theCBC_SPDSslot plan to minimize host local psi storage.Commit 3
CBCDuses the same static slot plan to minimize device local psi storage, and replaces the earlier per-angleset communicators with one aggregated communicator per groupset.CBCD_AsynchronousCommunicatorwith:CBCD_AngleSet,CBCD_FLUDS, andCBCDSweepChunkto:CBC_SPDSslot plan.The plot below shows strong-scaling comparisons on Tuo between CBCD V1 and CBCD V2 on 32k and 268k cell mesh problems, both with 448 directions and 1 groupset with 64 groups.
Some grind times are unavailable due to earlier binary instabilities on Tuo with Cray MPICH and ROCm. Once bank access has been restored on Tuo, the results will be updated.