Skip to content

fix(a11y): add labels and ARIA attributes to SearchBar #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ParthAggarwal16 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(a11y): add labels and ARIA attributes to SearchBar #739

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76a13f
fix(a11y): add labels and ARIA attributes to SearchBar
ParthAggarwal16 Feb 10, 2026
b5e3c76
docs: re-add explanatory comment for error text in SearchBar
ParthAggarwal16 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions application/frontend/src/pages/Search/components/SearchBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,25 @@ export const SearchBar = () => {
}
};

const inputId = 'navbar-search-input';
const errorId = 'navbar-search-error';
return (
<div className="navbar__search">
<form onSubmit={onSubmit}>
<Search className="search-icon" />
<label htmlFor={inputId} className="visually-hidden">
Search OpenCRE
</label>

<Search className="search-icon" aria-hidden="true" />

<input
id={inputId}
type="text"
placeholder="Search..."
value={search.term}
aria-label="Search OpenCRE"
aria-invalid={Boolean(search.error)}
aria-describedby={search.error ? errorId : undefined}
onChange={(e) =>
setSearch({
...search,
Expand All @@ -49,9 +59,16 @@ export const SearchBar = () => {
}
/>
</form>

{/* Error text */}
{search.error && <p className="search-error">{search.error}</p>}
{search.error && (
<p
id={errorId}
className="search-error"
role="alert"
>
{search.error}
</p>
)}
</div>
);
};