fix(a11y): add labels and ARIA attributes to SearchBar #739
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves accessibility of the search input in
Searchbar.tsxto get better supportchanges:
<label>element for search inputaria-invalidto indicate error statearia-describedbyto link input with error messagesrole="alert"so errors announced to screen readersaria-hidden="true"to decorative search iconI manually tested this by:
submitting an empty search to verify error announcements
verified ARIA attributes update correctly in browser devtools
check accessibility feedback using lighthouse
closes #687
