Skip to content

Bugfix: use a consistent coordinate space for CustomSlider drag #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omargfh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix: use a consistent coordinate space for CustomSlider drag #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions app/assets/javascripts/beak/widgets/ractives/subcomponent/custom-slider.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,26 +81,25 @@ RactiveCustomSlider = Ractive.extend({

return

getClientPosition: (event) ->
getClientPosition: (event) -> # document-space coordinates
switch @get('orientation')
when 'horizontal' then event.clientX or event.touches?[0]?.clientX
when 'vertical' then event.clientY or event.touches?[0]?.clientY
else event.clientX or event.touches?[0]?.clientX
when 'vertical' then (event.clientY or event.touches?[0]?.clientY) + window.scrollY
else (event.clientX or event.touches?[0]?.clientX) + window.scrollX

getSliderLength: (node) ->
getSliderLength: (node) -> # document-space coordinates
rect = node.getBoundingClientRect()
switch @get('orientation')
when 'horizontal' then rect.width
when 'vertical' then rect.height
else throw new Error("Invalid orientation: #{@get('orientation')}")

getSliderLengthFromNode: (node) ->
getSliderLengthFromNode: (node) -> # object-space coordinates
# Might look like a typo, but since rotation happens using
# CSS, the bounding box changes but the node's offsetWidth/Height
# do not. -Omar I. Aug 14, 2025
return node.offsetWidth

getSliderStart: (node) ->
getSliderStart: (node) -> # document-space coordinates
rect = node.getBoundingClientRect()
switch @get('orientation')
when 'horizontal' then rect.left + window.scrollX
Expand Down
Loading