Bugfix: use a consistent coordinate space for CustomSlider drag#460
Open
omargfh wants to merge 1 commit into
Open
Bugfix: use a consistent coordinate space for CustomSlider drag#460omargfh wants to merge 1 commit into
omargfh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Sliders calculate click position incorrectly when NetLogo Web simulation runtime overflows. This issue requires the
iframeitself to overflow, which does not happen on thewww.netlogoweb.org/launchbut happens onwww.netlogoweb.org/web.Diagnosis
The function
getClientPositioninReactiveCustomSlideruses viewport-space coordinates whilegetSliderStartandgetSliderLengthuse document-space coordinates. Due to howwww.netlogoweb.org/launchembeds the runtime simulation, those coordinate-spaces share the same basis and offset. This is not the case onbeta.modelingcommons.orgor when runningwww.netlogoweb.org/webin its own tab.Recreate
www.netlogoweb.org/webExpected behavior: slider snaps to mouse position on click and follows mouse on drag
Actual behavior: slider snaps to incorrect position, often at the extremes or by some noticeable offset from the mouse position
Fix
Convert
getClientPositionto document-space coordinates by adding the window scroll to its returned value.Closes #459