Increase code coverage#2051
Open
albinahlback wants to merge 5 commits intoNemocas:masterfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2051 +/- ##
==========================================
+ Coverage 88.36% 88.42% +0.05%
==========================================
Files 125 124 -1
Lines 31551 31543 -8
==========================================
+ Hits 27880 27891 +11
+ Misses 3671 3652 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
albinahlback
force-pushed
the
codecov
branch
6 times, most recently
from
75e734c to
c7227f1
Compare
fingolfin
reviewed
Apr 4, 2025
albinahlback
force-pushed
the
codecov
branch
2 times, most recently
from
6821069 to
d9344cc
Compare
This was referenced May 1, 2025
fingolfin
reviewed
Dec 10, 2025
Member
|
Just to say: this PR keeps getting smaller as we extract parts of it. I've just resolved merge conflicts again. But it really shows @albinahlback had (and has) an important point: our untested code contains a lot of basic issues, and we should strive to expand coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.