Remove bad generic sqrt method#2068
Merged
lgoettgens merged 1 commit intomasterfrom May 6, 2025
Merged
Conversation
Method dispatch does not take keyword arguments into account. Therefore the kind of dispatch used by this method is risky and can result in an infinite recursion.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2068 +/- ##
==========================================
+ Coverage 88.37% 88.38% +0.01%
==========================================
Files 125 125
Lines 31585 31580 -5
==========================================
- Hits 27913 27912 -1
+ Misses 3672 3668 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
approved these changes
May 2, 2025
lgoettgens
approved these changes
May 6, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
This changes a StackOverflowError to a MethodError for the cases that dispatched to this method, so IMO a clear improvement (and non-breaking as it just replaces on error by another one)
lgoettgens
added
the
release notes: use title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method dispatch does not take keyword arguments into account. Therefore the kind of dispatch used by this method is risky and can result in an infinite recursion.
Discovered while looking at test failures in PR #2051