fix: copy_object date range metadata copying#139

Closed

Hasakev wants to merge 35 commits into

NatLabRockies:mainfrom

Contributor

Hasakev commented May 20, 2026

Summary

Resolves #138.

This PR updates copy_object so copied objects preserve date-bounded property metadata.

Previously, _copy_object_properties copied the core t_data rows and related metadata such as t_tag, t_text, and t_band, but did not copy the associated t_date_from and t_date_to rows. This meant copied objects could lose date range metadata even though the main property rows were copied successfully.

Changes

Added copying of t_date_from rows using the existing temp_data_mapping table.
Added copying of t_date_to rows using the existing temp_data_mapping table.
Ensured copied date metadata is linked to the newly inserted t_data rows rather than the original rows.
Added/updated regression coverage for copying objects with date-bounded properties.

Why

copy_object should preserve all property-related metadata so that copied objects behave the same as the source object. Without copying t_date_from and t_date_to, properties with date ranges become incomplete after copying.

Testing

Confirmed copy_object preserves:
- t_data
- t_tag
- t_text
- t_band
- t_date_from
- t_date_to
Confirmed existing copy behaviour remains unchanged for already-supported metadata tables.
Added/ran regression test for copying an object with date-bounded property values.

Hasakev added 4 commits

May 20, 2026 11:59


          fix: add queries to copy date_from and date_to during copy object pro…

f815e72

…perties


          fix: add queries to copy date_from and date_to during copy object pro…

a048c14

…perties


          Merge branch 'main' of github.com:Hasakev/plexosdb

afde4cf


          fix: add queries to copy date_from and date_to during copy object pro…

1f3f7a8

…perties

Contributor

mcllerena commented May 20, 2026 •

edited

Loading

@Hasakev thanks for opening this PR. Could you sign your commits so that we can safely merge?

mcllerena self-requested a review

May 20, 2026 21:45


          Merge branch 'main' into main

93831a6

pesap changed the title ~~Fix: copy_object date range metadata copying~~ fix: copy_object date range metadata copying

mcllerena approved these changes

View reviewed changes

mcllerena requested a review from pesap

May 20, 2026 22:43

pesap approved these changes

View reviewed changes

mcllerena and others added 19 commits

May 21, 2026 10:20


          Merge branch 'main' into main

dc4257f


          fix: add queries to copy date_from and date_to during copy object pro…

3a9fb95

…perties


          fix: add queries to copy date_from and date_to during copy object pro…

e88ef67

…perties


          fix: add safe parsing for long int values (#140)

2023a12


          build(deps-dev): bump ipython from 9.8.0 to 9.13.0 (#137)

4c15ef7

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump astral-sh/setup-uv from 7.6.0 to 8.1.0 (#122)

309896e

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump googleapis/release-please-action from 4.4.0 to 4.4.1 (

508d0db

#123)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps-dev): bump sphinxcontrib-mermaid from 1.0.0 to 2.0.2 (#136)

0131f88

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1 (#121)

a0314b5

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump benchmark-action/github-action-benchmark from 1.21.…

9fe6590

…0 to 1.22.0 (#120)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump codecov/codecov-action from 5.5.3 to 6.0.0 (#118)

65fe6aa

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          chore(main): release 1.4.0 (#131)

30cb42c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Merge branch 'main' of github.com:Hasakev/plexosdb

5307e3f


          fix: add queries to copy date_from and date_to during copy object pro…

e880a38

…perties


          fix: add queries to copy date_from and date_to during copy object pro…

6cb2454

…perties


          Merge branch 'main' of github.com:Hasakev/plexosdb

df709b4


          fix: add queries to copy date_from and date_to during copy object pro…

2d2b12b

…perties


          Merge branch 'main' into main

41f54f4


          Merge branch 'main' into main

0b75132

mcllerena and others added 11 commits

May 22, 2026 10:07


          fix: add safe parsing for long int values (#140)

2ca2a76


          build(deps-dev): bump ipython from 9.8.0 to 9.13.0 (#137)

4d4c328

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump astral-sh/setup-uv from 7.6.0 to 8.1.0 (#122)

e0e1681

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump googleapis/release-please-action from 4.4.0 to 4.4.1 (

b3ae2a8

#123)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps-dev): bump sphinxcontrib-mermaid from 1.0.0 to 2.0.2 (#136)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1 (#121)

588d955

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump benchmark-action/github-action-benchmark from 1.21.…

180c0e6

…0 to 1.22.0 (#120)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          build(deps): bump codecov/codecov-action from 5.5.3 to 6.0.0 (#118)

3866f49

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marck Llerena V. <140716266+mcllerena@users.noreply.github.com>


          chore(main): release 1.4.0 (#131)

cd6cce2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Merge branch 'main' of github.com:Hasakev/plexosdb

d6b3b0f


          Merge branch 'main' of github.com:Hasakev/plexosdb

dfae20d

Contributor Author

Hasakev commented May 22, 2026 •

edited

Loading

I’m going to close this PR and reopen it from a clean branch.

I’ve been having trouble getting the existing rebased commits signed/verified correctly, so rather than keep rewriting this branch, I’ll recreate the changes with a clean signed commit history.

The new PR will contain the same fix for copying date_from and date_to during object property copying.
I'll also add a test for this case.

Hasakev closed this

Contributor

mcllerena commented May 22, 2026

Great, thanks you!

Hasakev mentioned this pull request

fix: copy_object date range metadata copying #143

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet