fix: copy_object date range metadata copying#143
Merged
Conversation
Collaborator
|
Thanks @Hasakev ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #139
Resolves #138
Summary
This pull request reapplies the changes from #139 to address #138. It improves the object-copying logic so that date-bound property values are preserved when objects are duplicated.
Previously,
date_fromanddate_tovalues associated with object properties were not copied to the newly created object. This could result in copied objects losing important temporal property metadata.Changes
Object property copying
_copy_object_propertiesinsrc/plexosdb/db.pyto explicitly copydate_fromanddate_tovalues when duplicating object properties.Tests
test_copy_object_copies_date_from_and_date_tointests/test_plexosdb_copy_object.py.date_fromanddate_toare preserved when copying an object.datetimeimport to support the new test case.Notes
This PR replaces the previous attempt in #139 after the changes were reapplied cleanly.