Skip to content

fix(e2e): dra tests#933

Merged
enoodle merged 11 commits intomainfrom
erez/fix-dra-e2e-tests
Feb 5, 2026
Merged

fix(e2e): dra tests#933
enoodle merged 11 commits intomainfrom
erez/fix-dra-e2e-tests

Conversation

@enoodle
Copy link
Collaborator

@enoodle enoodle commented Jan 27, 2026

Description

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

Additional Notes

@enoodle enoodle force-pushed the erez/fix-dra-e2e-tests branch 2 times, most recently from afb808c to 582086e Compare January 27, 2026 00:13
SiorMeir
SiorMeir previously approved these changes Jan 27, 2026
@enoodle enoodle force-pushed the erez/fix-dra-e2e-tests branch 5 times, most recently from eb13096 to df110f4 Compare February 2, 2026 12:43
@enoodle enoodle mentioned this pull request Feb 2, 2026
3 tasks
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation 93.36% (-0.06%) 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation.go 93.36% (-0.06%) 211 (-2) 197 (-2) 14 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/pod.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/resource_claim.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources/dra_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt/preempt_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware/timeaware_suite_test.go

davidLif
davidLif previously approved these changes Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation 93.36% (-0.06%) 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation.go 93.36% (-0.06%) 211 (-2) 197 (-2) 14 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/pod.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/resource_claim.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources/dra_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt/preempt_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware/timeaware_suite_test.go

@enoodle enoodle force-pushed the erez/fix-dra-e2e-tests branch 3 times, most recently from 3f4ee17 to 2bb25c7 Compare February 4, 2026 10:44
@enoodle enoodle force-pushed the erez/fix-dra-e2e-tests branch from 7bb1b42 to 7855f4a Compare February 4, 2026 14:26
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation 93.36% (-0.06%) 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/scheduling_shard 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/predicates 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation.go 93.36% (-0.06%) 211 (-2) 197 (-2) 14 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/node.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/pod.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/resource_claim.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/scheduling_shard/scheduling_shard.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order/resource_type_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/predicates/affinity_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources/dra_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt/preempt_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/reclaim/hierarchy_level_fairness_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware/timeaware_suite_test.go

Add JSON report generation and parse it to display a summary of
skipped tests at the end of the e2e test run for better visibility.
@enoodle enoodle force-pushed the erez/fix-dra-e2e-tests branch from 7855f4a to e617ba3 Compare February 4, 2026 19:13
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation 93.36% (-0.06%) 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/scheduling_shard 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/predicates 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation.go 93.36% (-0.06%) 211 (-2) 197 (-2) 14 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/node.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/pod.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/resource_claim.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/scheduling_shard/scheduling_shard.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order/resource_type_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/predicates/affinity_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources/dra_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt/preempt_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/reclaim/hierarchy_level_fairness_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware/timeaware_suite_test.go

@enoodle enoodle added this pull request to the merge queue Feb 5, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch erez/fix-dra-e2e-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation 93.36% (-0.06%) 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/scheduling_shard 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/predicates 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/binder/binding/resourcereservation/resource_reservation.go 93.36% (-0.06%) 211 (-2) 197 (-2) 14 👎
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/node.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/pod.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/resource_claim.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/test/e2e/modules/resources/rd/scheduling_shard/scheduling_shard.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/node_order/resource_type_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/predicates/affinity_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/allocate/resources/dra_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/preempt/preempt_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/reclaim/hierarchy_level_fairness_test.go
  • github.com/NVIDIA/KAI-scheduler/test/e2e/suites/timeaware/timeaware_suite_test.go

@enoodle enoodle added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit ab77361 Feb 5, 2026
13 of 14 checks passed
@enoodle enoodle deleted the erez/fix-dra-e2e-tests branch February 5, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants