Open
Conversation
Contributor
Author
Collaborator
|
@rich7420 Currently the DRA e2e tests are all not functioning so we don't have a way to test it. Did you get to test them with this change? |
Contributor
Author
|
I didn’t get to run the DRA e2e tests with this change ,they’re not working in CI right now. The code mirrors the scheduler’s CEL logic in |
Collaborator
Contributor
Author
|
@enoodle got it! thanks for the reminder |
enoodle
reviewed
Feb 3, 2026
|
|
||
| func ListDevicesByNode(clientset kubernetes.Interface, deviceClass string) map[string]int { | ||
| // ListDevicesByNode counts devices per node that match the given DeviceClass selectors (CEL). | ||
| // If the DeviceClass doesn't exist, the test is skipped. If it has no selectors, all devices match. |
Collaborator
There was a problem hiding this comment.
The fallback should be to the current behavior, or no device at all.
enoodle
reviewed
Feb 3, 2026
| } | ||
| } | ||
|
|
||
| // CleanupResourceClaims deletes all ResourceClaims with the engine-e2e label in the given namespace. |
Collaborator
There was a problem hiding this comment.
Lets avoid obvious comments on code that didn't change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The original test code used slice.Spec.Driver != deviceClass to filter devices, which is incorrect. DeviceClass names are not the same as drivers, and we should use CEL selectors to determine if a device belongs to a DeviceClass.
Related Issues
Fixes #
Checklist
Breaking Changes
Additional Notes