issue-551: Restricting python version and removing pkg_resources#552
issue-551: Restricting python version and removing pkg_resources#552EmilyPascua wants to merge 3 commits intomasterfrom
Conversation
|
@EmilyPascua Overall looks good, tho I noticed a lot of the pretty alignment from pyproject.toml was removed? I tend to be pro-alignment so was wondering if it was violating some convention? |
@nttoole Thanks Nicko! The auto formatter on my IDE updated it, but I can revert it back. Will push a change for this. |
|
Tests failing due to still expecting other python versions; though sphinx is failing due to using pkg_resources.
|
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.7", "3.8", "3.9", "3.10"] | ||
| python-version: ["3.10"] |
There was a problem hiding this comment.
Should 3.11 be included at this point, or no?
|
|
||
| def getDefaultSchema(): # noqa | ||
| return pkg_resources.resource_filename("ait.core", "data/cmd_schema.json") | ||
| return files("ait.core").joinpath("data/cmd_schema.json") |
There was a problem hiding this comment.
Do these need a str() call to ensure return type is maintained?
| 3.8.15 | ||
| 3.9.15 | ||
| 3.10.8 | ||
| 3.10.20 |
2 participants
Pull request to address #551 ; this removes support for python 3.7 which has already reached eol. Restricting python version to >= 3.10 < 3.11.