Quantize coordinates on save (#20)#41
Open
MisterGC wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20 — auto-save now writes integer-pixel coordinates so a 1-px drag produces a 1-line diff instead of ~14 digits of float noise.
grafli/format.py: single_q()helper rounds box / note / image x/y/w/h and arrow@dx,dylabel offsets on serialize; replaces the per-field "emit int when it happens to equal int(v)" checks. Drops arrow offset entirely when both components round to 0.examples/*.grafli: re-saved through the new serializer to remove the float noise already present in the repo (4 files; ~83 lines re-saved per file). Legitimate decimals inside labels (v0.1.0,2.0) are untouched.Test plan
pytest -q— 332 passedexamples/showcase.grafliand save;git diffshould show a 1-line integer-coord change with no float noise