Skip to content

fix: remove getMinimumBalanceForRentExemption from the codebase #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghgoodreau wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: remove getMinimumBalanceForRentExemption from the codebase #7715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd8fcc4
fix: remove getMinimumBalanceForRentExemption from the codebase
ghgoodreau Jan 23, 2026
cdc884c
chore: lint
ghgoodreau Jan 23, 2026
c711a20
chore: update changelog
ghgoodreau Jan 23, 2026
ff794bd
fix: lint eslint-suppressions.json file
ghgoodreau Jan 23, 2026
992c464
chore: mark as breaking change in changelog.md
ghgoodreau Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,15 +567,15 @@
},
"packages/bridge-controller/src/bridge-controller.test.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 2
"count": 1
},
"@typescript-eslint/prefer-nullish-coalescing": {
"count": 1
}
},
"packages/bridge-controller/src/bridge-controller.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 18
"count": 17
},
"@typescript-eslint/naming-convention": {
"count": 4
Expand All @@ -588,7 +588,7 @@
},
"packages/bridge-controller/src/selectors.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 25
"count": 24
},
"@typescript-eslint/naming-convention": {
"count": 1
Expand Down Expand Up @@ -702,7 +702,7 @@
},
"packages/bridge-controller/src/utils/snaps.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 3
"count": 1
}
},
"packages/bridge-controller/src/utils/swaps.ts": {
Expand Down
4 changes: 4 additions & 0 deletions packages/bridge-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated s3 link in mock ([#7710](https://github.com/MetaMask/core/pull/7710))

### Removed
Copy link
Member

@micaelae micaelae Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark this as a breaking change? Clients will need to update their tests when upgrading the controller


- **BREAKING:** Remove `getMinimumBalanceForRentExemptionInLamports`, `getMinimumBalanceForRentExemptionRequest`, `selectMinimumBalanceForRentExemptionInSOL`, and `minimumBalanceForRentExemptionInLamports` from state ([#7715](https://github.com/MetaMask/core/pull/7715))

## [64.8.1]

### Changed
Expand Down
2 changes: 0 additions & 2 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.sse.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ Object {
"usdExchangeRate": "100",
},
},
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": Object {
"destChainId": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
Expand Down Expand Up @@ -270,7 +269,6 @@ Object {
"usdExchangeRate": "100",
},
},
"minimumBalanceForRentExemptionInLamports": "0",
"quoteFetchError": null,
"quoteRequest": Object {
"destChainId": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
Expand Down
354 changes: 2 additions & 352 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading