Skip to content

Conversation

@ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Jan 23, 2026

Explanation

Removes the usage of getMinimumBalanceForRentExemption from the bridge controllers.

References

Fixes: MetaMask/metamask-extension#34971

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

BREAKING — Removed Solana rent‑exemption min balance integration

  • Delete minimumBalanceForRentExemptionInLamports from BridgeController state and metadata; remove related reset/update paths
  • Remove selectMinimumBalanceForRentExemptionInSOL selector and its export from index.ts
  • Remove snaps utilities getMinimumBalanceForRentExemptionRequest and getMinimumBalanceForRentExemptionInLamports; keep computeFeeRequest
  • Strip #setMinimumBalanceForRentExemptionInLamports and the non‑awaited call from bridge-controller.ts; drop isSolanaChainId import usage
  • Update tests and snapshots to exclude the removed state/requests; delete failing/rent‑exemption specific test blocks
  • Documented in CHANGELOG.md under Removed

Written by Cursor Bugbot for commit 992c464. This will update automatically on new commits. Configure here.

@ghgoodreau ghgoodreau requested a review from a team as a code owner January 23, 2026 17:22
@ghgoodreau ghgoodreau requested a review from a team as a code owner January 23, 2026 18:07
@ghgoodreau ghgoodreau marked this pull request as draft January 23, 2026 18:12
@ghgoodreau ghgoodreau marked this pull request as ready for review January 23, 2026 18:35

- Updated s3 link in mock ([#7710](https://github.com/MetaMask/core/pull/7710))

### Removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark this as a breaking change? Clients will need to update their tests when upgrading the controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error setting minimum balance for rent exemption

3 participants