Fixed semi-random card movement after moving hands right#5
Open
Henotu wants to merge 1 commit intoKyle-P:masterfrom
Open
Fixed semi-random card movement after moving hands right#5Henotu wants to merge 1 commit intoKyle-P:masterfrom
Henotu wants to merge 1 commit intoKyle-P:masterfrom
Conversation
|
Hey, seeing as the original dev is kinda absent, I tried implementing your changes into the mod by adding them directly into the lua script in a copy of the original Workshop .json file, and while the 0 rotation from Zero-Seven rule seems to be working, the 7 exchange between players is still broken, as tested between two players right now. Cards get stuck along the way in the empty hands of "absent players", for example. Are you planning to look into that? |
Author
|
At one point, I tried fixing the 7 exchange bug, but I had no success in it. In my Testing though, the cards didn't end up in a random hand and only changed their order. That's why I didn't end up fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also keeps the order of the card the same.
Im currently trying to fix the it in the
clickTakeHandButton(obj, color)function, but the bug it seems to be a bit different