Skip to content

Fixed switching of the cards after a "7" is played#6

Open
Henotu wants to merge 1 commit intoKyle-P:masterfrom
Henotu:7switch-fix
Open

Fixed switching of the cards after a "7" is played#6
Henotu wants to merge 1 commit intoKyle-P:masterfrom
Henotu:7switch-fix

Conversation

@Henotu
Copy link

@Henotu Henotu commented Nov 5, 2021

As requested by @Lernos in #5, I fixed the 7-switch by using the build in function deal(). Because of some issues, I had to build in a delay.

@Lernos
Copy link

Lernos commented Nov 5, 2021

Great, 7 seems to be working properly. Thanks! However, I bear bad news once again. Upon testing this commit with 3 players this time, we found out that, despite the game direction being clockwise (signified by the arrow above your name on the turn indicator), 0 would only switch hands in the counter-clockwise manner. Upon reversing the direction counter-clockwise, it worked as it should. We then reversed it back to clockwise to test it one more time and... well, one player to the right of me, let's call them A, had 3 cards, and me and player B had tons of them. The 3 cards mysteriously disappeared, and I was left with an empty hand, while both player A and player B received the aforementioned "tons of cards". We suspect the 3 cards went into player B's hand, although it was difficult to determine. Also, player B claimed his cards were flipped over to their backs (as you would manually do with F key by default). So that time, instead of just switching hands counter-clockwise despite the clockwise direction, 0 just messed up and left me with an empty hand. Yikes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants