Skip to content

Tidy internal linkage and two stale/dead details #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ViralBShah wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Tidy internal linkage and two stale/dead details #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/autodetection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ int32_t autodetect_interface(void * handle, const char * suffix) {
// those.
build_symbol_name(symbol_name, "dpotrf_", suffix);
void * dpotrf = lookup_symbol(handle, symbol_name);
if (ilaver != NULL || dpotrf != NULL) {
// NB: if `ilaver` were non-NULL we'd already have returned above, so it's
// guaranteed NULL here; only `dpotrf` matters.
if (dpotrf != NULL) {
return autodetect_lapack_interface_dpotrf(dpotrf);
}

Expand Down
3 changes: 2 additions & 1 deletion src/config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ void clear_forwarding_mark(int32_t symbol_idx, int32_t interface) {
}
}

void clear_other_forwards(int skip_idx, uint8_t * forwards, int32_t interface) {
// Only used within this file; keep it out of the library's exported symbols.
static void clear_other_forwards(int skip_idx, uint8_t * forwards, int32_t interface) {
for (int idx=0; idx<MAX_TRACKED_LIBS; ++idx) {
if (lbt_config.loaded_libs[idx] == NULL) {
return;
Expand Down
2 changes: 1 addition & 1 deletion src/libblastrampoline_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ int32_t autodetect_complex_return_style(void * handle, const char * suffix);
int32_t autodetect_f2c(void * handle, const char * suffix);
int32_t autodetect_cblas_divergence(void * handle, const char * suffix);

// Functions in deepbindless_surrogates.c
// Functions in deepbindless.c
uint8_t push_fake_lsame();
uint8_t pop_fake_lsame();
int fake_lsame(char * ca, char * cb);
Expand Down
Loading