Tidy internal linkage and two stale/dead details#178
Draft
ViralBShah wants to merge 1 commit into
Draft
Conversation
Three small, behavior-preserving cleanups found during a structural review: - `clear_other_forwards()` is only used within `config.c`, but lacked a declaration and was an accidental exported symbol. Mark it `static` (confirmed no longer in the dynamic symbol table). - Fix a stale comment in `libblastrampoline_internal.h`: the surrogate functions live in `deepbindless.c`, not `deepbindless_surrogates.c`. - Simplify a dead condition in `autodetect_interface()`: the `ilaver != NULL` disjunct can never be true there (we return earlier when `ilaver` is found), so the check is just `dpotrf != NULL`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, behavior-preserving cleanups found during a structural review:
clear_other_forwards()had accidental external linkage. It's used only withinsrc/config.cand isn't declared in the internal header, yet it was an exported library symbol. Markedstatic(verified: no longer present innm -Doutput).Stale comment in
src/libblastrampoline_internal.h: the surrogate functions live indeepbindless.c, notdeepbindless_surrogates.c.Dead condition in
autodetect_interface()(src/autodetection.c): theilaver != NULLdisjunct can never be true at that point (the function returns earlier whenilaveris found), so the guard is simplydpotrf != NULL.Builds cleanly. Draft for review.