[IP-85]: import export options all data#582
Draft
nielsdrost7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6262f3f to
b78dcf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import/export options for all data (#85): export (CSV + Excel, v2 and V1-legacy formats) ships for all nine modules (Clients/Contacts, Invoices, Quotes, Payments, Products, Projects/Tasks, Expenses) with list-page actions; the V1 database migration path ships as the
import:dbcommand (Modules/Core/Commands/ImportInvoicePlaneV1Command.php) + per-entity import services (Modules/Core/Services/Import/*ImportService.php) +ImportOrchestrator.The Filament
ImportAction-based per-module import UI is not part of this PR — that remains with the child issues (#139, #140, #141, #80), attached below.Update 2026-07-04 — branch revived and green
develop— the PR is mergeable again.import_v1MySQL connection; without one their setUp/tearDown errored and leaked an open transaction that cascaded "There is already an active transaction" into 265 unrelated tests. They now skip cleanly when no import database is reachable (they still run whereverIMPORT_DB_*points at a real source).relations.company_name,products.product_name,expenses.expense_amount,payments.payment_amount/notes, and payments now get the invoice their NOT NULLinvoice_idrequires.Full suite: 0 failed / 323 passed / 64 skipped / 9 incomplete (fork develop baseline: 272 passed).
Closes
Closes #85 — import/export options for all data: CSV+Excel export (v2 and V1-legacy) for all 9 modules, V1 database migration via
import:dbFollow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #139 — Import options (catalog, pricelists) — Filament ImportAction UI not built; only the CLI
import:dbpath existsCloses #140 — Import products from external sources — no Filament ImportAction wizard for Products
Closes #141 — Import clients in bulk for data migration — no Filament ImportAction wizard for Clients
Closes #80 — Finish create import for Excel — Filament ImportAction-based per-module import UI remains unbuilt across the board
Test plan
php artisan test— full suite, expect 0 failed (323 passed / 64 skipped / 9 incomplete on sqlite in-memory)php artisan import:dbagainst a real InvoicePlane v1 database — spot check a few entities