[IP-160]: convert quote to invoice#579
Draft
nielsdrost7 wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
09bc5a6 to
254cc6d
Compare
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuoteService::convertQuoteToInvoice(Quote): Invoice— inside a transaction: copiesprospect_id → customer_id, all quote items (name, qty, price, discounts, both tax rates, task link), the discount/tax/total summary, andsummary/terms/footeronto a new draft invoice; then sets the quote to the newQuoteStatus::CONVERTEDcase.Deviation from the SMART plan: no redirect to
EditInvoiceafter conversion — that page didn't exist on develop when this PR was written. It does now (further extended by PR #575), so the redirect is a ready-to-do follow-up (#588).Closes
Closes #160 — quote-to-invoice conversion implemented end-to-end (service, action, status transition)
Follow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #588 — Redirect to the invoice edit page after converting a quote (now unblocked since
EditInvoiceexists on develop)Tests
QuoteConversionTest— 3 tests: full conversion (items, totals, status), double-conversion rejection, action visibility.