[IP-543]: quote edit page#576
Draft
nielsdrost7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cePlane#543, InvoicePlane#222) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
060486b to
ba5c131
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuotesTablewith navigation to a dedicatedEditRecordpage (EditQuote)editroute inQuoteResource::getPages()Header actions
QuoteService::duplicateQuote(), redirects to new edit pageAPPROVEDandREJECTEDquotesCloses
Closes #543 — EditQuote page (parent)
Closes #222 — Quote action bar: download PDF / send email / convert to invoice / copy quote
Follow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #196 — Download PDF stub (quote edit page action still shows a "not yet implemented" toast; #196 tracks the download-PDF capability for quotes)
Closes #199 — Send Email stub (quote edit page action still shows a "not yet implemented" toast; #199 tracks the send-by-email capability for quotes)
Related: #160 — Convert to Invoice stub (implemented separately in PR #579, which closes it; this PR only stubs the header action)
Test plan
DRAFTstatus → Delete is visibleAPPROVEDstatus → Delete is hiddenREJECTEDstatus → Delete is hidden