Skip to content

[IP-543]: quote edit page#576

Draft
nielsdrost7 wants to merge 1 commit into
InvoicePlane:developfrom
underdogg-forks:feature/543-quote-edit-page
Draft

[IP-543]: quote edit page#576
nielsdrost7 wants to merge 1 commit into
InvoicePlane:developfrom
underdogg-forks:feature/543-quote-edit-page

Conversation

@nielsdrost7

@nielsdrost7 nielsdrost7 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces the inline modal edit in QuotesTable with navigation to a dedicated EditRecord page (EditQuote)
  • Adds status-aware header action bar to the quote edit page, matching the top-right dropdown users expect from InvoicePlane v1
  • Registers the edit route in QuoteResource::getPages()

Header actions

Action Condition
Download PDF Always (stub — tracked in #196)
Send Email Always (stub — tracked in #199)
Convert to Invoice Always (stub — #160, implemented in PR #579)
Copy Quote Always — delegates to QuoteService::duplicateQuote(), redirects to new edit page
Delete Hidden for APPROVED and REJECTED quotes

Closes

Closes #543 — EditQuote page (parent)
Closes #222 — Quote action bar: download PDF / send email / convert to invoice / copy quote

Follow-up issues (not resolved here — reopen if auto-closed on merge)

Closes #196 — Download PDF stub (quote edit page action still shows a "not yet implemented" toast; #196 tracks the download-PDF capability for quotes)
Closes #199 — Send Email stub (quote edit page action still shows a "not yet implemented" toast; #199 tracks the send-by-email capability for quotes)

Related: #160 — Convert to Invoice stub (implemented separately in PR #579, which closes it; this PR only stubs the header action)

Test plan

  • Open a quote in DRAFT status → Delete is visible
  • Open a quote in APPROVED status → Delete is hidden
  • Open a quote in REJECTED status → Delete is hidden
  • Copy Quote → creates a duplicate quote, redirects to its edit page
  • PDF / Email / Convert to Invoice stubs show "Not yet implemented" warning toast

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c7a3662-9c94-457a-babf-1aee834cc04b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nielsdrost7 nielsdrost7 changed the title Feature/543 quote edit page [IP-543]: quote edit page Jul 4, 2026
@nielsdrost7 nielsdrost7 self-assigned this Jul 4, 2026
@nielsdrost7 nielsdrost7 force-pushed the feature/543-quote-edit-page branch from 060486b to ba5c131 Compare July 4, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant