Skip to content

Remove emotional language and add Crowdin automation workflow#290

Merged
nielsdrost7 merged 5 commits into
developfrom
copilot/sub-pr-282
Dec 29, 2025
Merged

Remove emotional language and add Crowdin automation workflow#290
nielsdrost7 merged 5 commits into
developfrom
copilot/sub-pr-282

Conversation

Copilot AI commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Addresses review feedback to prepare the repository for alpha release by removing non-technical language and adding translation automation.

Changes

  • Documentation cleanup: Removed emotional language ("love", emojis) from markdown files and workflow output, while preserving technical testing terminology

    • .github/CHECKLIST.md: Preserved "(happy)" column suffixes - "happy paths" is a technical testing term
    • .github/workflows/release.yml: Removed emojis from GitHub Actions summary
    • README.md: Changed "Made with ❤️ by" to "Developed by"
  • Crowdin translation workflow: Added .github/workflows/crowdin-sync.yml with three action modes:

    • upload-sources: Push English files to Crowdin
    • download-translations: Pull translations (default, runs weekly)
    • sync-bidirectional: Both directions
    • Auto-creates PRs with translation updates
    • Documented in MAINTENANCE.md with detailed GitHub secrets setup instructions (Settings → Secrets and variables → Actions)
    • Documented in workflows/README.md
  • Guidelines maintenance: Updated .junie/guidelines.md timestamp to 2025-12-29

All 9 GitHub Actions workflows have workflow_dispatch configured for manual execution.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 29, 2025 15:37
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
@InvoicePlane InvoicePlane deleted a comment from coderabbitai Bot Dec 29, 2025
Copilot AI changed the title [WIP] Update files based on review feedback for PR #282 Remove emotional language and add Crowdin automation workflow Dec 29, 2025
Copilot AI requested a review from nielsdrost7 December 29, 2025 15:42
@nielsdrost7 nielsdrost7 requested a review from Copilot December 29, 2025 15:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the InvoicePlane v2 repository for alpha release by removing emotional language from documentation and adding automated translation management through Crowdin.

Key Changes:

  • Removed non-technical language (emojis, emotional phrases like "happy", "love") from markdown files and GitHub Actions workflow outputs
  • Added automated Crowdin translation synchronization workflow with three action modes (upload, download, bidirectional sync) and weekly scheduled runs
  • Updated documentation to describe the new Crowdin workflow in both MAINTENANCE.md and workflows/README.md

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Changed "Made with ❤️ by" to "Developed by" for professional tone
.junie/guidelines.md Updated "Last Updated" timestamp to current date (2025-12-29)
.github/workflows/release.yml Removed emoji decorations from GitHub Actions summary output
.github/workflows/crowdin-sync.yml New workflow for automated translation sync with Crowdin, featuring scheduled runs and manual dispatch options
.github/workflows/README.md Added documentation section describing the new Crowdin sync workflow, its triggers, and requirements
.github/THEMES.md Changed "love" to "prefer" in Nord theme description for neutral language
.github/MAINTENANCE.md Added comprehensive documentation for Crowdin translation sync workflow including setup and usage instructions
.github/CHECKLIST.md Removed "(happy)" suffixes from test coverage table column headers

Review Summary: The changes successfully achieve the stated goals of removing emotional language while adding valuable automation infrastructure. The Crowdin workflow is well-structured with appropriate permissions, error handling, and documentation. All changes maintain consistency with the project's professional standards and are ready for alpha release.

Comment thread .github/CHECKLIST.md Outdated
Comment thread .github/MAINTENANCE.md Outdated
Copilot AI and others added 2 commits December 29, 2025 15:53
…ions

Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Copilot AI requested a review from nielsdrost7 December 29, 2025 15:56
@InvoicePlane InvoicePlane deleted a comment from coderabbitai Bot Dec 29, 2025
@nielsdrost7 nielsdrost7 marked this pull request as ready for review December 29, 2025 15:58
@nielsdrost7 nielsdrost7 merged commit 2d4c896 into develop Dec 29, 2025
1 check passed
@nielsdrost7 nielsdrost7 deleted the copilot/sub-pr-282 branch December 29, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants