Remove emotional language and add Crowdin automation workflow#290
Merged
Conversation
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update files based on review feedback for PR #282
Remove emotional language and add Crowdin automation workflow
Dec 29, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the InvoicePlane v2 repository for alpha release by removing emotional language from documentation and adding automated translation management through Crowdin.
Key Changes:
- Removed non-technical language (emojis, emotional phrases like "happy", "love") from markdown files and GitHub Actions workflow outputs
- Added automated Crowdin translation synchronization workflow with three action modes (upload, download, bidirectional sync) and weekly scheduled runs
- Updated documentation to describe the new Crowdin workflow in both MAINTENANCE.md and workflows/README.md
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Changed "Made with ❤️ by" to "Developed by" for professional tone |
.junie/guidelines.md |
Updated "Last Updated" timestamp to current date (2025-12-29) |
.github/workflows/release.yml |
Removed emoji decorations from GitHub Actions summary output |
.github/workflows/crowdin-sync.yml |
New workflow for automated translation sync with Crowdin, featuring scheduled runs and manual dispatch options |
.github/workflows/README.md |
Added documentation section describing the new Crowdin sync workflow, its triggers, and requirements |
.github/THEMES.md |
Changed "love" to "prefer" in Nord theme description for neutral language |
.github/MAINTENANCE.md |
Added comprehensive documentation for Crowdin translation sync workflow including setup and usage instructions |
.github/CHECKLIST.md |
Removed "(happy)" suffixes from test coverage table column headers |
Review Summary: The changes successfully achieve the stated goals of removing emotional language while adding valuable automation infrastructure. The Crowdin workflow is well-structured with appropriate permissions, error handling, and documentation. All changes maintain consistency with the project's professional standards and are ready for alpha release.
nielsdrost7
requested changes
Dec 29, 2025
…ions Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback to prepare the repository for alpha release by removing non-technical language and adding translation automation.
Changes
Documentation cleanup: Removed emotional language ("love", emojis) from markdown files and workflow output, while preserving technical testing terminology
.github/CHECKLIST.md: Preserved "(happy)" column suffixes - "happy paths" is a technical testing term.github/workflows/release.yml: Removed emojis from GitHub Actions summaryREADME.md: Changed "Made with ❤️ by" to "Developed by"Crowdin translation workflow: Added
.github/workflows/crowdin-sync.ymlwith three action modes:upload-sources: Push English files to Crowdindownload-translations: Pull translations (default, runs weekly)sync-bidirectional: Both directionsMAINTENANCE.mdwith detailed GitHub secrets setup instructions (Settings → Secrets and variables → Actions)workflows/README.mdGuidelines maintenance: Updated
.junie/guidelines.mdtimestamp to 2025-12-29All 9 GitHub Actions workflows have
workflow_dispatchconfigured for manual execution.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.