Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f58b35a
feat(docker): Added image build script
mbloechli May 16, 2025
8795402
feat(cli): Added a command line interface for starting/stopping simul…
mbloechli May 16, 2025
02218b0
fix(description): allow for upper and lowercase when defining boolean…
mbloechli May 16, 2025
c7feac9
test(cli): added tests for spawn and delete function in robot_manager
mbloechli May 16, 2025
a271202
fix(dockerfile): Install docker inside image
mbloechli May 16, 2025
2247796
fix(ci): export logs also when tests fail
mbloechli May 16, 2025
fa250ae
fix(ci): added ros_domain env variable
mbloechli May 16, 2025
1028745
fix(ci): execute colcon tests sequentially
mbloechli May 16, 2025
50c54c3
fix(ci): run test_container in host net and ROS_DOMAIN_ID 42
May 24, 2025
75f7587
fix(cli): delete robot spawn container after stopping
May 24, 2025
bd7ff8c
fix(cli): raise timeout during testing from 2 to 10 seconds
May 24, 2025
f00a45a
fix(ci): change image tag to helmoro
May 24, 2025
9874169
feat(devcontainer): mount docker.sock
mbloechli Jun 2, 2025
bde79d2
refactor(compose): change name of description service to robot_descri…
mbloechli Jun 2, 2025
0027c4d
fix(cli): added newline to __init__.py to conform with python convention
mbloechli Jun 2, 2025
d177180
doc(simulation): explained in comments more clearly, how the update t…
mbloechli Jun 2, 2025
42ed489
fix(compose): wrong path to main.py
mbloechli Jun 3, 2025
3deef21
fix(config): typo setub.bash -> setup.bash
mbloechli Jun 3, 2025
a7e0379
fix(Dockerfile): update outdated GPG keys
mbloechli Jun 3, 2025
cdd0be1
doc(cli): add comments
mbloechli Jun 3, 2025
0accd63
refactor: created a helmoro_utils pkg containing common test cases
mbloechli Jun 3, 2025
5d79de5
refactor(cli): exchanged topic test with test from helmoro_utils pkg
mbloechli Jun 3, 2025
59b3b16
refactor: move docker specific files into seperate folder
mbloechli Jun 4, 2025
47d8d53
doc(Dockerfile): added comments
mbloechli Jun 4, 2025
8ee30b9
doc(cli): added a README
mbloechli Jun 4, 2025
18a916a
refactor(description): use lowercase for true and false
mbloechli Jun 4, 2025
9dbf05f
feat(cli): add function to delete all robots
mbloechli Jun 4, 2025
476a3d8
fix(cli): corrected env input for container starts, solves failing ro…
mbloechli Jun 4, 2025
95fbbaa
refactor(utils): change filename for better readability
mbloechli Jun 5, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def append_unique_lines_to_bashrc(source_file):
print("ℹ️ No new lines were added. All lines already exist.")

if __name__ == "__main__":
append_unique_lines_to_bashrc(os.path.abspath("/home/ws/config/append_to_bashrc.txt"))
append_unique_lines_to_bashrc(os.path.abspath("/home/ws/.devcontainer/append_to_bashrc.txt"))

# If there are arguments passed to this container (i.e., CMD), run them
if len(sys.argv) > 1:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Custom Alias
alias src='source /opt/ros/jazzy/setub.bash && source /home/ws/install/setup.bash'
alias src='source /opt/ros/jazzy/setup.bash && source /home/ws/install/setup.bash'

# Integrate entrypoint.sh
source /home/ws/.devcontainer/entrypoint.sh
7 changes: 4 additions & 3 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"privileged": true,
"remoteUser": "htkz",
"build": {
"dockerfile": "Dockerfile",
"dockerfile": "../docker/Dockerfile",
"context": "..",
"target": "dev",
"args": {
Expand Down Expand Up @@ -43,7 +43,8 @@
"mounts": [
"source=/tmp/.X11-unix,target=/tmp/.X11-unix,type=bind,consistency=cached",
"source=/dev/dri,target=/dev/dri,type=bind,consistency=cached",
"source=/dev/input,target=/dev/input,type=bind,consistency=delegated"
"source=/dev/input,target=/dev/input,type=bind,consistency=delegated",
"source=/var/run/docker.sock,target=/var/run/docker.sock,type=bind"
],
"postCreateCommand": "sudo chown -R $(whoami) /home/ws/ && python3 /home/ws/config/append_to_bashrc.py"
"postCreateCommand": "sudo chown -R $(whoami) /home/ws/ && python3 /home/ws/.devcontainer/append_to_bashrc.py"
}
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ jobs:
uses: docker/build-push-action@v6
with:
context: .
file: .devcontainer/Dockerfile
tags: ghcr.io/helbling-technik/helmoro-software-ros2:${{ github.ref_name }}-latest
file: docker/Dockerfile
tags: helmoro
Comment thread
jonaslondschien-helbling marked this conversation as resolved.
load: true
cache-from: |
type=gha
Expand All @@ -41,7 +41,7 @@ jobs:

- name: Start container
shell: bash
run: docker run --name test_container -v /tmp/.X11-unix:/tmp/.X11-unix --detach ghcr.io/helbling-technik/helmoro-software-ros2:${{ github.ref_name }}-latest tail -f /dev/null
run: docker run --name test_container --net host -v /tmp/.X11-unix:/tmp/.X11-unix -v /var/run/docker.sock:/var/run/docker.sock --detach helmoro tail -f /dev/null

- name: Run test
shell: bash
Expand All @@ -51,17 +51,19 @@ jobs:
echo "Starting virtual display (Xvfb)..."
Xvfb :99 -screen 0 1024x768x24 &
export DISPLAY=:99
export ROS_DOMAIN_ID=42

echo "Start testing..."
docker exec -e DISPLAY=$DISPLAY test_container bash -c "
docker exec -e DISPLAY=$DISPLAY -e ROS_DOMAIN_ID=$ROS_DOMAIN_ID test_container bash -c "
source ./entrypoint.sh &&
colcon test &&
colcon test --executor sequential &&
Comment thread
jonaslondschien-helbling marked this conversation as resolved.
colcon test-result --verbose
"

- name: Export logs to runner
shell: bash
run: docker cp test_container:/home/ws/log ./log
if: always() # export logs even if tests fail

- name: Upload logs
uses: actions/upload-artifact@v4
Expand Down
25 changes: 22 additions & 3 deletions .devcontainer/Dockerfile → docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
FROM ros@sha256:9749355a0760334fa5ea3c660f2de1ecc5e8a5af8047e4bbaa9afa8a7843da80 AS dev
FROM osrf/ros@sha256:f2f03a667950570edcaa14ed414a636912acd44ea9c25c10b5a7c5d44eea5142 AS dev

# NOTE: this updates the GPG key for ros2 apt repository (to be deleted when new ros2 jazzy docker image is released)
RUN rm /etc/apt/sources.list.d/ros2-latest.list \
&& rm /usr/share/keyrings/ros2-latest-archive-keyring.gpg

RUN apt-get update \
&& apt-get install -y ca-certificates curl

RUN export ROS_APT_SOURCE_VERSION=$(curl -s https://api.github.com/repos/ros-infrastructure/ros-apt-source/releases/latest | grep -F "tag_name" | awk -F\" '{print $4}') ;\
curl -L -s -o /tmp/ros2-apt-source.deb "https://github.com/ros-infrastructure/ros-apt-source/releases/download/${ROS_APT_SOURCE_VERSION}/ros2-apt-source_${ROS_APT_SOURCE_VERSION}.$(. /etc/os-release && echo $VERSION_CODENAME)_all.deb" \
&& apt-get update \
&& apt-get install /tmp/ros2-apt-source.deb \
&& rm -f /tmp/ros2-apt-source.deb

# ********************************************************
# * Install Dependencies *
# ********************************************************
Expand All @@ -18,8 +31,14 @@ RUN sudo apt update && sudo apt install -y \
RUN apt-get update && apt-get install -y \
xterm \
xvfb \
curl \
&& rm -rf /var/lib/apt/lists/*

# Install Docker Engine
RUN curl -fsSL https://get.docker.com -o get-docker.sh && \
sh get-docker.sh && \
rm get-docker.sh

# Install ROS debug packages
RUN apt-get update && apt-get install -y \
ros-jazzy-demo-nodes-cpp \
Expand Down Expand Up @@ -78,7 +97,7 @@ ENV SHELL=/bin/bash

# Define entrypoint
RUN mkdir -p /home/ws
COPY .devcontainer/entrypoint.sh /home/ws
COPY docker/entrypoint.sh /home/ws
RUN chmod +x /home/ws/entrypoint.sh
ENTRYPOINT [ "/home/ws/entrypoint.sh" ]
CMD ["/bin/bash"]
Expand All @@ -94,7 +113,7 @@ FROM dev AS prod
# Copy our packages into the image and build them
USER root
WORKDIR /home/ws
COPY config config
COPY src src
COPY docker/docker-compose.yml docker/
RUN source /opt/ros/jazzy/setup.bash \
&& colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release
1 change: 1 addition & 0 deletions docker/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
sudo docker build -t helmoro -f docker/Dockerfile .
56 changes: 56 additions & 0 deletions docker/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
services:
template:
command: bash
image: helmoro
environment:
- DISPLAY=${DISPLAY}
- ROS_DOMAIN_ID=42
network_mode: host
ipc: host
volumes:
- /tmp/.X11-unix:/tmp/.X11-unix

cli:
extends: template
command: python3 src/helmoro_cli/helmoro_cli/main.py
volumes:
- /var/run/docker.sock:/var/run/docker.sock

simulation:
extends: template
command: bash -c "ros2 launch helmoro_simulation simulation.launch.py world:=$${WORLD}"
environment:
- WORLD

spawn_robot:
extends: template
command: bash -c "ros2 launch helmoro_simulation spawn_robot.launch.py namespace:=$${NAMESPACE} x:=$${X} y:=$${Y} z:=$${Z} yaw:=$${YAW}"
environment:
- NAMESPACE
- X
- Y
- Z
- YAW

despawn_robot:
extends: template
command: bash -c "ros2 launch ros_gz_sim gz_remove_model.launch.py world:=$${WORLD} entity_name:=$${ENTITY_NAME}"
environment:
- WORLD
- ENTITY_NAME

gz_ros_bridge:
extends: template
command: bash -c "ros2 launch helmoro_simulation ros_gz_bridge.launch.py namespace:=$${NAMESPACE} word:=$${WORLD}"
environment:
- NAMESPACE
- WORLD

robot_description:
extends:
service: template
command: bash -c "ros2 launch helmoro_description description.launch.py namespace:=$${NAMESPACE} run_in_simulation:=$${USE_SIM_TIME}"
environment:
- NAMESPACE
- USE_SIM_TIME

File renamed without changes.
202 changes: 202 additions & 0 deletions src/helmoro_cli/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,202 @@

Comment thread
jonaslondschien-helbling marked this conversation as resolved.
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
Loading