Skip to content

[No QA] chore: LHNOptionsList cleanup — hoist isWeb, deduplicate reportAttributes, remove duplicate guard #86647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 1 commit into from
Apr 1, 2026
+7 −15
Merged

[No QA] chore: LHNOptionsList cleanup — hoist isWeb, deduplicate reportAttributes, remove duplicate guard #86647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions src/components/LHNOptionsList/LHNOptionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import type {LHNOptionsListProps, RenderItemProps} from './types';
import useEmptyLHNIllustration from './useEmptyLHNIllustration';

const keyExtractor = (item: Report) => `report_${item.reportID}`;
const platform = getPlatform();
const isWeb = platform === CONST.PLATFORM.WEB;

function LHNOptionsList({style, contentContainerStyles, data, onSelectRow, optionMode, shouldDisableFocusOptions = false, onFirstItemRendered = () => {}}: LHNOptionsListProps) {
const {saveScrollOffset, getScrollOffset, saveScrollIndex, getScrollIndex} = useContext(ScrollOffsetContext);
Expand All @@ -60,21 +62,15 @@ function LHNOptionsList({style, contentContainerStyles, data, onSelectRow, optio
const isReportsSplitNavigatorLast = useRootNavigationState((state) => state?.routes?.at(-1)?.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR);
const shouldShowEmptyLHN = data.length === 0;
const estimatedItemSize = optionMode === CONST.OPTION_MODE.COMPACT ? variables.optionRowHeightCompact : variables.optionRowHeight;
const platform = getPlatform();
const isWeb = platform === CONST.PLATFORM.WEB;
const emptyLHNIllustration = useEmptyLHNIllustration();

const firstReportIDWithGBRorRBR = useMemo(() => {
const firstReportWithGBRorRBR = data.find((report) => {
const itemReportErrors = reportAttributes?.[report.reportID]?.reportErrors;
if (!report) {
return false;
}
if (!isEmptyObject(itemReportErrors)) {
const attrs = reportAttributes?.[report.reportID];
if (!isEmptyObject(attrs?.reportErrors)) {
return true;
}
const hasGBR = reportAttributes?.[report.reportID]?.requiresAttention;
return hasGBR;
return attrs?.requiresAttention;
});

return firstReportWithGBRorRBR?.reportID;
Expand Down Expand Up @@ -226,10 +222,6 @@ function LHNOptionsList({style, contentContainerStyles, data, onSelectRow, optio
return;
}

if (!flashListRef.current) {
return;
}

// If the option mode changes want to scroll to the top of the list because rendered items will have different height.
flashListRef.current.scrollToOffset({offset: 0});
}, [previousOptionMode, optionMode]);
Expand All @@ -247,7 +239,7 @@ function LHNOptionsList({style, contentContainerStyles, data, onSelectRow, optio
}
triggerScrollEvent();
},
[estimatedItemSize, isWeb, route, saveScrollIndex, saveScrollOffset, triggerScrollEvent],
[estimatedItemSize, route, saveScrollIndex, saveScrollOffset, triggerScrollEvent],
);

const onLayout = useCallback(() => {
Expand All @@ -264,7 +256,7 @@ function LHNOptionsList({style, contentContainerStyles, data, onSelectRow, optio
}
flashListRef.current.scrollToOffset({offset});
});
}, [getScrollOffset, route, isWeb]);
}, [getScrollOffset, route]);

// eslint-disable-next-line rulesdir/prefer-early-return
useEffect(() => {
Expand Down
Loading